refactor: deprecate featurep! for modulep!

featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.

modules/completion/helm/autoload/evil.el

@@ -1,5 +1,5 @@
 ;;; completion/helm/autoload/evil.el -*- lexical-binding: t; -*-
-;;;###if (featurep! :editor evil)
+;;;###if (modulep! :editor evil)
 
 ;;;###autoload (autoload '+helm:project-search "completion/helm/autoload/evil" nil t)
 (evil-define-command +helm:project-search (all-files-p query)

modules/completion/helm/autoload/helm.el

@@ -18,7 +18,7 @@
   "A version of `helm-buffers-list' with its buffer list restricted to the
 current workspace."
   (interactive)
-  (unless (featurep! :ui workspaces)
+  (unless (modulep! :ui workspaces)
     (user-error "This command requires the :ui workspaces module"))
   (with-no-warnings
     (with-persp-buffer-list nil (helm-buffers-list))))
@@ -28,7 +28,7 @@ current workspace."
   "A version of `helm-mini' with its buffer list restricted to the current
 workspace."
   (interactive)
-  (unless (featurep! :ui workspaces)
+  (unless (modulep! :ui workspaces)
     (user-error "This command requires the :ui workspaces module"))
   (with-no-warnings
     (with-persp-buffer-list nil (helm-mini))))

modules/completion/helm/config.el

@@ -63,17 +63,17 @@ Can be negative.")
         ;; disable special behavior for left/right, M-left/right keys.
         helm-ff-lynx-style-map nil)
 
-  (when (featurep! :editor evil +everywhere)
+  (when (modulep! :editor evil +everywhere)
     (setq helm-default-prompt-display-function #'+helm--set-prompt-display))
 
   :init
-  (when (featurep! +childframe)
+  (when (modulep! +childframe)
     ;; If this is set to 'iconify-top-level then Emacs will be minimized upon
     ;; helm completion.
     (setq iconify-child-frame 'make-invisible)
     (setq helm-display-function #'+helm-posframe-display-fn))
 
-  (let ((fuzzy (featurep! +fuzzy)))
+  (let ((fuzzy (modulep! +fuzzy)))
     (setq helm-apropos-fuzzy-match fuzzy
           helm-bookmark-show-location fuzzy
           helm-buffers-fuzzy-matching fuzzy
@@ -117,7 +117,7 @@ Can be negative.")
     (advice-add fn :around #'doom-use-helpful-a)))
 
 (use-package! helm-flx
-  :when (featurep! +fuzzy)
+  :when (modulep! +fuzzy)
   :hook (helm-mode . helm-flx-mode)
   :config (helm-flx-mode +1))
 
@@ -154,7 +154,7 @@ Can be negative.")
 
 
 (use-package! helm-org
-  :when (featurep! :lang org)
+  :when (modulep! :lang org)
   :defer t
   :init
   (after! helm-mode
@@ -188,7 +188,7 @@ Can be negative.")
 
 (use-package! helm-icons
   :after helm
-  :when (featurep! +icons)
+  :when (modulep! +icons)
   :init
   (setq helm-icons-provider 'all-the-icons)
   :config

modules/completion/helm/packages.el

@@ -10,12 +10,12 @@
   :pin "11fb36af119b784539d31c6160002de1957408aa")
 (package! helm-projectile :pin "58123f14c392021714fc5d23b9f95c7f95ce07f1")
 (package! swiper-helm :pin "93fb6db87bc6a5967898b5fd3286954cc72a0008")
-(when (featurep! +fuzzy)
+(when (modulep! +fuzzy)
   (package! helm-flx :pin "27dd9e3ce385a3ca15092150e65781de14b5b00b"))
-(when (featurep! +childframe)
+(when (modulep! +childframe)
   (package! posframe :pin "c91d4d53fa479ceb604071008ce0a901770eff57"))
-(when (featurep! :lang org)
+(when (modulep! :lang org)
   (package! helm-org :pin "d67186d3a64e610c03a5f3d583488f018fb032e4"))
-(when (featurep! +icons)
+(when (modulep! +icons)
   (package! helm-icons :pin "8d2f5e705c8b78a390677cf242024739c932fc95"))
 (package! helm-descbinds :pin "b72515982396b6e336ad7beb6767e95a80fca192")