From acb5af177b0a57ca4b05d00d5055d109198e2984 Mon Sep 17 00:00:00 2001 From: 45mm <45mm@no.mail> Date: Thu, 18 Jan 2024 16:20:15 +0530 Subject: [PATCH] fix(vertico): don't shell-quote consult-ripgrep-args We were using `shell-quote-argument`, which is meant for passing file names, strings and so on, not command-line arguments. For example, `(shell-quote-argument "--foo=bar")` yields "--foo\\=bar", which is obviiously invalid unless we're trying to pass an option named '--foo\'. At any rate, there is no quoting/escaping for shells in the default value of `consult-ripgrep-args`, so it doesn't look like this is something we need to do. --- modules/completion/vertico/autoload/vertico.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/completion/vertico/autoload/vertico.el b/modules/completion/vertico/autoload/vertico.el index 0199d431d..0b4219eaf 100644 --- a/modules/completion/vertico/autoload/vertico.el +++ b/modules/completion/vertico/autoload/vertico.el @@ -31,7 +31,7 @@ "--path-separator / --smart-case --no-heading " "--with-filename --line-number --search-zip " "--hidden -g !.git -g !.svn -g !.hg " - (mapconcat #'shell-quote-argument args " "))) + (mapconcat #'identity args " "))) (prompt (if (stringp prompt) (string-trim prompt) "Search")) (query (or query (when (doom-region-active-p)