emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bump: :tools lsp

Browse source 
emacs-lsp/lsp-mode@6b6afc00de -> emacs-lsp/lsp-mode@3fa645c039
joaotavora/eglot@e835996e16 -> joaotavora/eglot@bd970be047

- There are multiple issues in the lsp-mode
  repo (emacs-lsp/lsp-mode#2722), lsp-julia repo (gdkrmr/lsp-julia#23
  and gdkrmr/lsp-julia#35), and the LanguageServer.jl
  repo (julia-vscode/LanguageServer.jl#844) about crashes of the Julia
  LSP with lsp-mode due to errors caused by the folding capabilities
  announced by the client. One can work around these issues by enabling
  folding (see gdkrmr/lsp-julia#23) but that is only a hack and does not
  fix the underlying issue. The problem is caused by a violation of the
  LSP specs in lsp-mode which was fixed in emacs-lsp/lsp-mode#3593. The
  PR updates lsp-mode to the latest commit on the master branch which
  contains this fix (and some other unrelated fixes, CI passes
  successfully again), and hence the workaround for lsp-julia can be
  removed.

Ref: emacs-lsp/lsp-mode#3593
Ref: emacs-lsp/lsp-mode#2722
Ref: gdkrmr/lsp-julia#35
Ref: gdkrmr/lsp-julia#23
Ref: julia-vscode/LanguageServer.jl#844
Close: #6516
Co-authored-by: devmotion <devmotion@users.noreply.github.com>
This commit is contained in:
Henrik Lissner 2022-07-05 01:35:06 +02:00
parent e4a1e4c909
commit acae9f9acb
No known key found for this signature in database
GPG key ID: B60957CA074D39A3
2 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/lang/julia/config.el
View file

@ -80,12 +80,7 @@
(unless lsp-julia-default-environment (unless lsp-julia-default-environment
(setq lsp-julia-default-environment (setq lsp-julia-default-environment
(or (car (last (doom-glob "~/.julia/environments/v*"))) (or (car (last (doom-glob "~/.julia/environments/v*")))
"~/.julia/environments/v1.6"))) "~/.julia/environments/v1.6"))))
:config
;; See non-Jedi/lsp-julia#35
(setq-hook! 'julia-mode-hook
lsp-enable-folding t
lsp-folding-range-limit 100))
(use-package! eglot-jl (use-package! eglot-jl

6
modules/tools/lsp/packages.el
View file

@ -3,11 +3,11 @@
(if (featurep! +eglot) (if (featurep! +eglot)
(progn (progn
(package! eglot :pin "e835996e16610d0ded6d862214b3b452b8803ea8") (package! eglot :pin "bd970be047aba4513c2970b9ff2d842f0472cb0e")
(when (featurep! :completion vertico) (when (featurep! :completion vertico)
(package! consult-eglot :pin "0da8801dd8435160ce1f62ad8066bd52e38f5cbd"))) (package! consult-eglot :pin "0da8801dd8435160ce1f62ad8066bd52e38f5cbd")))
(package! lsp-mode :pin "6b6afc00deec6dacb78834c02ed5f262e72ce337") (package! lsp-mode :pin "3fa645c0397b8f438f2db2dd288b899ba330d410")
(package! lsp-ui :pin "a0b97db2ada163453c9072d3640202a0b27c29f5") (package! lsp-ui :pin "0a6368d38dc32e52abcbd52b63d1e557e42c66e6")
(when (featurep! :completion ivy) (when (featurep! :completion ivy)
(package! lsp-ivy :pin "3e87441a625d65ced5a208a0b0442d573596ffa3")) (package! lsp-ivy :pin "3e87441a625d65ced5a208a0b0442d573596ffa3"))
(when (featurep! :completion helm) (when (featurep! :completion helm)