From a8dc291971a9fe1d413f6de6603db4cadb3993f1 Mon Sep 17 00:00:00 2001 From: Ellis Kenyo Date: Thu, 4 May 2023 07:01:00 +0100 Subject: [PATCH] fix(lsp): warn about server installers for lsp-mode Having the warning show up for Eglot is confusing UX since it doesn't apply. --- modules/tools/lsp/doctor.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/tools/lsp/doctor.el b/modules/tools/lsp/doctor.el index 1739bfddb..e7cecb997 100644 --- a/modules/tools/lsp/doctor.el +++ b/modules/tools/lsp/doctor.el @@ -4,6 +4,7 @@ (modulep! +peek))) "+eglot and +peek flags are not compatible. Peek uses lsp-mode, while Eglot is another package altogether for LSP.") -(unless (executable-find "npm") +(unless (and (not (modulep! +eglot)) + (executable-find "npm")) (warn! "Couldn't find npm, most server installers won't work and will have to be installed manually. For more information, see https://emacs-lsp.github.io/lsp-mode/page/languages/."))