Major refactor: use-package-always-defer = nil & use :hook

Possibly breaking change: packages are no longer deferred by default.

Addresses #286

modules/ui/doom-modeline/config.el

@@ -1,7 +1,6 @@
 ;;; ui/doom-modeline/config.el -*- lexical-binding: t; -*-
 
 (def-package! eldoc-eval
-  :demand t
   :config
   (defun +doom-modeline-eldoc (text)
     (concat (when (display-graphic-p)
@@ -28,7 +27,7 @@
 ;; anzu and evil-anzu expose current/total state that can be displayed in the
 ;; mode-line.
 (def-package! evil-anzu
-  :when (featurep 'evil)
+  :requires evil
   :init
   (add-transient-hook! #'evil-ex-start-search (require 'evil-anzu))
   (add-transient-hook! #'evil-ex-start-word-search (require 'evil-anzu))

modules/ui/doom/config.el

@@ -2,7 +2,6 @@
 
 ;; <https://github.com/hlissner/emacs-doom-theme>
 (def-package! doom-themes
-  :demand t
   :config
   (set! :theme 'doom-one)
 
@@ -32,26 +31,15 @@
 
 
 (def-package! solaire-mode
-  :commands (solaire-mode turn-on-solaire-mode turn-off-solaire-mode)
-  :init
-  (add-hook 'after-change-major-mode-hook #'turn-on-solaire-mode)
-  (add-hook 'doom-popup-mode-hook #'turn-off-solaire-mode)
+  :hook (gist-mode twittering-mode mu4e-view-mode org-tree-slide-mode +regex-mode)
+  :hook (after-change-major-mode . turn-on-solaire-mode)
+  :hook (doom-popup-mode . turn-off-solaire-mode)
+  :hook (doom-init-ui . solaire-mode-swap-bg)
   :config
   (setq solaire-mode-real-buffer-fn #'doom-real-buffer-p)
-  (add-hook 'doom-init-ui-hook #'solaire-mode-swap-bg t)
-
   ;; Prevent color glitches when reloading either DOOM or the theme
-  (defun +doom|reset-solaire-mode (&rest _) (solaire-mode-reset))
-  (advice-add #'load-theme :after #'+doom|reset-solaire-mode)
-  (add-hook! '(doom-init-ui-hook doom-reload-hook) #'solaire-mode-reset)
-
-  ;; Extra modes to activate doom-buffer-mode in
-  (add-hook! (gist-mode
-              twittering-mode
-              mu4e-view-mode
-              org-tree-slide-mode
-              +regex-mode)
-    #'solaire-mode))
+  (advice-add #'load-theme :after #'solaire-mode-reset)
+  (add-hook! '(doom-init-ui-hook doom-reload-hook) #'solaire-mode-reset))
 
 
 (after! hideshow

modules/ui/evil-goggles/config.el

@@ -2,8 +2,7 @@
 
 (def-package! evil-goggles
   :when (featurep! :feature evil)
-  :commands evil-goggles-mode
+  :hook (doom-post-init . evil-goggles-mode)
   :init
   (setq evil-goggles-duration 0.1
-        evil-goggles-enable-delete nil)
-  (add-hook 'doom-post-init-hook #'evil-goggles-mode t))
+        evil-goggles-enable-delete nil))

modules/ui/hl-todo/config.el

@@ -1,8 +1,7 @@
 ;;; ui/hl-todo/packages.el -*- lexical-binding: t; -*-
 
 (def-package! hl-todo
-  :commands hl-todo-mode
-  :init (add-hook 'prog-mode-hook #'hl-todo-mode)
+  :hook (prog-mode . hl-todo-mode)
   :config
   (setq hl-todo-keyword-faces
         `(("TODO"  . ,(face-foreground 'warning))

modules/ui/tabbar/config.el

@@ -5,7 +5,6 @@
 ;; find ivy (or helm) or even `buffer-menu' is better suited for this purpose.
 
 (def-package! tabbar
-  :demand t
   :config
   (setq tabbar-use-images nil)
   (tabbar-mode)

modules/ui/vi-tilde-fringe/config.el

@@ -3,8 +3,8 @@
 ;; indicators for empty lines past EOF
 (def-package! vi-tilde-fringe
   :commands (global-vi-tilde-fringe-mode vi-tilde-fringe-mode)
+  :hook (doom-init-ui . global-vi-tilde-fringe-mode)
   :init
-  (add-hook 'doom-init-ui-hook #'global-vi-tilde-fringe-mode)
   :config
   (defun +vi-tilde-fringe|disable ()
     (vi-tilde-fringe-mode -1)))