Minor refactors across the board

- when-let* -> when-let
- Fix projectile-locate-dominating-file for connected remote files

modules/tools/eval/config.el

@@ -15,7 +15,7 @@
 
   (defun +eval*quickrun-auto-close (&rest _)
     "Allows us to silently re-run quickrun from within the quickrun buffer."
-    (when-let* ((win (get-buffer-window quickrun--buffer-name)))
+    (when-let (win (get-buffer-window quickrun--buffer-name))
       (let ((inhibit-message t))
         (quickrun--kill-running-process)
         (message ""))
@@ -41,7 +41,7 @@
 
   (defun +eval|quickrun-shrink-window ()
     "Shrink the quickrun output window once code evaluation is complete."
-    (when-let* ((win (get-buffer-window quickrun--buffer-name)))
+    (when-let (win (get-buffer-window quickrun--buffer-name))
       (with-selected-window (get-buffer-window quickrun--buffer-name)
         (let ((ignore-window-parameters t))
           (shrink-window-if-larger-than-buffer)))))
@@ -49,7 +49,7 @@
 
   (defun +eval|quickrun-scroll-to-bof ()
     "Ensures window is scrolled to BOF on invocation."
-    (when-let* ((win (get-buffer-window quickrun--buffer-name)))
+    (when-let (win (get-buffer-window quickrun--buffer-name))
       (with-selected-window win
         (goto-char (point-min)))))
   (add-hook 'quickrun-after-run-hook #'+eval|quickrun-scroll-to-bof))

modules/tools/flyspell/autoload.el

@@ -16,7 +16,7 @@
 ;;;###autoload
 (defun +flyspell|init-predicate ()
   "TODO"
-  (when-let* ((pred (assq major-mode +flyspell--predicate-alist)))
+  (when-let (pred (assq major-mode +flyspell--predicate-alist))
     (setq-local flyspell-generic-check-word-predicate (cdr pred))))
 
 ;;;###autoload

modules/tools/lookup/autoload/docsets.el

@@ -65,7 +65,7 @@ Docsets must be installed with one of the following commands:
 + `dash-docs-async-install-docset-from-file'
 
 Docsets can be searched directly via `+lookup/in-docsets'."
-  (when-let* ((docsets (cl-remove-if-not #'dash-docs-docset-path (dash-docs-buffer-local-docsets))))
+  (when-let (docsets (cl-remove-if-not #'dash-docs-docset-path (dash-docs-buffer-local-docsets)))
     (+lookup/in-docsets nil identifier docsets)
     'deferred))
 

modules/tools/lookup/autoload/online.el

@@ -6,11 +6,11 @@
   (let ((key (or namespace major-mode)))
     (or (and (not force-p)
              (cdr (assq key +lookup--last-provider)))
-        (when-let* ((provider
-                     (completing-read
-                      "Search on: "
-                      (mapcar #'car +lookup-provider-url-alist)
-                      nil t)))
+        (when-let (provider
+                   (completing-read
+                    "Search on: "
+                    (mapcar #'car +lookup-provider-url-alist)
+                    nil t))
           (setf (alist-get key +lookup--last-provider) provider)
           provider))))
 

modules/tools/magit/config.el

@@ -98,7 +98,7 @@ It is passed a user and repository name.")
     [tab] #'magit-section-toggle)
   (after! git-rebase
     (dolist (key '(("M-k" . "gk") ("M-j" . "gj")))
-      (when-let* ((desc (assoc (car key) evil-magit-rebase-commands-w-descriptions)))
+      (when-let (desc (assoc (car key) evil-magit-rebase-commands-w-descriptions))
         (setcar desc (cdr key))))
     (evil-define-key* evil-magit-state git-rebase-mode-map
       "gj" #'git-rebase-move-line-down

modules/tools/prodigy/autoload.el

@@ -12,7 +12,7 @@
   "Delete service at point. Asks for confirmation."
   (interactive "P")
   (prodigy-with-refresh
-   (when-let* ((service (prodigy-service-at-pos)))
+   (when-let (service (prodigy-service-at-pos))
      (let ((name (plist-get service :name)))
        (cond ((or arg
                   (y-or-n-p (format "Delete '%s' service?" name)))