emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Move byte-compile fix to core-packages

Browse source 
So it targets more than just 28.x+ users.
This commit is contained in:
Henrik Lissner 2021-02-06 04:49:28 -05:00
parent c7458e9e2e
commit 9446a8f411
2 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

21
core/core-lib.el
View file

@ -749,26 +749,7 @@ made obsolete, for example a date or a release number.
See the docstrings of `defalias' and `make-obsolete' for more details." See the docstrings of `defalias' and `make-obsolete' for more details."
(declare (doc-string 4)) (declare (doc-string 4))
`(progn (defalias ,obsolete-name ,current-name ,docstring) `(progn (defalias ,obsolete-name ,current-name ,docstring)
(make-obsolete ,obsolete-name ,current-name ,when))) (make-obsolete ,obsolete-name ,current-name ,when))))
(defadvice! doom--byte-compile-in-same-session-a (recipe)
"Straight recompiles packages from an Emacs child process. This is sensible,
but many packages don't properly load their macro dependencies, causing errors,
which we can't possibly police, so I revert straight to its old strategy of
compiling in the same session."
:override #'straight--build-compile
(straight--with-plist recipe (package)
;; These two `let' forms try very, very hard to make byte-compilation an
;; invisible process. Lots of packages have byte-compile warnings; I
;; don't need to know about them and neither do straight.el users.
(letf! (;; Prevent Emacs from asking the user to save all their
;; files before compiling.
(#'save-some-buffers #'ignore))
(quiet!
;; Note that there is in fact no `byte-compile-directory' function.
(byte-recompile-directory
(straight--build-dir package)
0 'force))))))
(provide 'core-lib) (provide 'core-lib)
;;; core-lib.el ends here ;;; core-lib.el ends here

19
core/core-packages.el
View file

@ -111,6 +111,25 @@ uses a straight or package.el command directly).")
(append (apply orig-fn args) ; lockfiles still take priority (append (apply orig-fn args) ; lockfiles still take priority
(doom-package-pinned-list))) (doom-package-pinned-list)))
(defadvice! doom--byte-compile-in-same-session-a (recipe)
"Straight recompiles packages from an Emacs child process. This is sensible,
but many packages don't properly load their macro dependencies, causing errors,
which we can't possibly police, so I revert straight to its old strategy of
compiling in the same session."
:override #'straight--build-compile
(straight--with-plist recipe (package)
;; These two `let' forms try very, very hard to make byte-compilation an
;; invisible process. Lots of packages have byte-compile warnings; I
;; don't need to know about them and neither do straight.el users.
(letf! (;; Prevent Emacs from asking the user to save all their
;; files before compiling.
(#'save-some-buffers #'ignore))
(quiet!
;; Note that there is in fact no `byte-compile-directory' function.
(byte-recompile-directory
(straight--build-dir package)
0 'force)))))
;; ;;
;;; Bootstrappers ;;; Bootstrappers