From 93ebe4a4bb7d89ebb2196e813a2a8f31d83e0481 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20M=C3=B8ller?= Date: Thu, 23 Jan 2020 12:58:39 +0100 Subject: [PATCH] Moved adding of helm-hide-minibuffer-maybe hook From a racy when condition in the posframe autoload, into an unconditional hook in the helm config.el file. --- modules/completion/helm/autoload/posframe.el | 3 --- modules/completion/helm/config.el | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/completion/helm/autoload/posframe.el b/modules/completion/helm/autoload/posframe.el index 2c64d5fa8..9ed53bb27 100644 --- a/modules/completion/helm/autoload/posframe.el +++ b/modules/completion/helm/autoload/posframe.el @@ -10,9 +10,6 @@ bottom, which is easier on the eyes on big displays." (truncate (/ (frame-pixel-height parent-frame) 2))))) -(when helm-echo-input-in-header-line - (add-hook 'helm-minibuffer-set-up-hook #'helm-hide-minibuffer-maybe)) - (defvar +helm--posframe-buffer nil) ;;;###autoload (defun +helm-posframe-display-fn (buffer &optional _resume) diff --git a/modules/completion/helm/config.el b/modules/completion/helm/config.el index 60d238d80..5f1666850 100644 --- a/modules/completion/helm/config.el +++ b/modules/completion/helm/config.el @@ -114,6 +114,9 @@ be negative.") (advice-add #'helm-display-mode-line :override #'+helm--hide-mode-line) (advice-add #'helm-ag-show-status-default-mode-line :override #'ignore) + ;; Hide minibuffer if `helm-echo-input-in-header-line' + (add-hook 'helm-minibuffer-set-up-hook #'helm-hide-minibuffer-maybe) + ;; Use helpful instead of describe-* to display documentation (dolist (fn '(helm-describe-variable helm-describe-function)) (advice-add fn :around #'doom-use-helpful-a)))