emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Make def-setting! behave more like defmacro

Browse source 
set! used to aggressively evaluate its arguments (at expansion-time),
even if placed inside an after! block. This causes unavoidable errors if
those arguments use functions/variables that don't exist yet.

Fixes #112
This commit is contained in:
Henrik Lissner 2017-06-19 00:22:04 +02:00
parent 27cbd36b69
commit 928812da8a
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
12 changed files with 104 additions and 107 deletions
Download patch file Download diff file Expand all files Collapse all files

12
modules/app/irc/config.el
View file

@ -15,9 +15,6 @@
(defvar +irc-notifications-watch-strings nil
"TODO")
(defvar +irc-connections nil
"A list of connections set with :irc. W")
(defvar +irc-defer-notifications nil
"How long to defer enabling notifications, in seconds (e.g. 5min = 300).
Useful for ZNC users who want to avoid the deluge of notifications during buffer
@ -25,8 +22,9 @@ playback.")
(def-setting! :irc (server letvars)
"Registers an irc server for circe."
`(cl-pushnew (cons ,server ,letvars) +irc-connections
:test #'equal :key #'car))
`(after! circe
(cl-pushnew (cons ,server ,letvars) circe-network-options
:test #'equal :key #'car)))
(defvar +irc--defer-timer nil)
@ -39,10 +37,6 @@ playback.")
:commands (circe circe-server-buffers)
:init (setq circe-network-defaults nil)
:config
;; change hands
(setq circe-network-options +irc-connections)
(defvaralias '+irc-connections 'circe-network-options)
(defsubst +irc--pad (left right)
(format (format "%%%ds | %%s" +irc-left-padding)
(concat "*** " left) right))