emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Rename unmap! to undefine-key!

Browse source 
unmap! gives the false impression that it is related or similar to map!,
but it isn't.
This commit is contained in:
Henrik Lissner 2020-04-23 23:41:03 -04:00
parent 28ec59cd20
commit 916ef0fbbe
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
3 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
core/core-keybinds.el
View file

@ -77,7 +77,8 @@ all hooks after it are ignored.")
:init :init
;; Convenience aliases ;; Convenience aliases
(defalias 'define-key! #'general-def) (defalias 'define-key! #'general-def)
(defalias 'unmap! #'general-unbind)) (defalias 'undefine-key! #'general-unbind))
;; HACK `map!' uses this instead of `define-leader-key!' because it consumes ;; HACK `map!' uses this instead of `define-leader-key!' because it consumes
;; 20-30% more startup time, so we reimplement it ourselves. ;; 20-30% more startup time, so we reimplement it ourselves.

2
docs/getting_started.org
View file

@ -910,7 +910,7 @@ also be helpful for debugging.
+ define-key + define-key
+ global-set-key + global-set-key
+ map! + map!
+ unmap! + undefine-key!
+ define-key! + define-key!
** Writing your own modules ** Writing your own modules

2
modules/tools/magit/config.el
View file

@ -162,7 +162,7 @@ ensure it is built when we actually use Forge."
(setq evil-magit-state 'normal (setq evil-magit-state 'normal
evil-magit-use-z-for-folds t) evil-magit-use-z-for-folds t)
:config :config
(unmap! magit-mode-map (undefine-key! magit-mode-map
;; Replaced by z1, z2, z3, etc ;; Replaced by z1, z2, z3, etc
"M-1" "M-2" "M-3" "M-4" "M-1" "M-2" "M-3" "M-4"
"1" "2" "3" "4" "1" "2" "3" "4"