💥 Replace core-popup with new feature/popup module

This is a breaking change! Update your :popup settings. Old ones will
throw errors!

Doom's new popup management system casts off its shackles (hur hur) and
replaces them with the monster that is `display-buffer-alist`, and
window parameters.

However, this is highly experimental! Expect edge cases.  Particularly
with org-mode and magit (or anything that does its own window
management).

Relevant to #261, #263, #325
This commit is contained in:
Henrik Lissner 2018-01-06 01:23:22 -05:00
parent 065091bdca
commit 91357a3e5d
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
33 changed files with 631 additions and 1038 deletions

View file

@ -8,18 +8,16 @@
(def-package! imenu-list
:commands imenu-list-minor-mode
:config
(setq imenu-list-focus-after-activation t)
(set! :popup imenu-list-buffer-name :size 35 :align 'right)
(set! :popup "^\\*Ilist"
'((side . right) (size . 35))
'((escape-quit . current) (select) (transient . 0)))
;; use popups
(defun doom*imenu-list-show ()
(doom-popup-buffer (get-buffer imenu-list-buffer-name)))
(advice-add #'imenu-list-show :override #'doom*imenu-list-show)
(advice-add #'imenu-list-show-noselect :override #'doom*imenu-list-show)
;; auto kill imenu-list on deactivation
(defun doom|kill-imenu-list ()
(when (and (not imenu-list-minor-mode)
(get-buffer imenu-list-buffer-name))
(kill-buffer (get-buffer imenu-list-buffer-name))))
(add-hook 'imenu-list-minor-mode-hook #'doom|kill-imenu-list))
(defun +imenu|cleanup-on-popup-close ()
"Clean up after `imenu-list-minor-mode' when killing the list window."
(unless +popup-buffer-mode
(when imenu-list--displayed-buffer
(with-current-buffer imenu-list--displayed-buffer
(imenu-list-minor-mode -1)))
(when (equal (buffer-name) imenu-list-buffer-name)
(kill-buffer (get-buffer imenu-list-buffer-name)))))
(add-hook '+popup-buffer-mode-hook #'+imenu|cleanup-on-popup-close))