💥 Replace core-popup with new feature/popup module

This is a breaking change! Update your :popup settings. Old ones will
throw errors!

Doom's new popup management system casts off its shackles (hur hur) and
replaces them with the monster that is `display-buffer-alist`, and
window parameters.

However, this is highly experimental! Expect edge cases.  Particularly
with org-mode and magit (or anything that does its own window
management).

Relevant to #261, #263, #325

modules/lang/clojure/config.el

@@ -35,7 +35,7 @@
   (setq nrepl-hide-special-buffers t)
 
   ;; settings for cider repl as a popup (prevent it from being closed on escape, especially.)
-  (set! :popup "^\\*cider" :regexp t :noselect t :noesc t)
+  (set! :popup "^\\*cider" nil '((escape-quit) (select)))
 
   ;; Setup cider for clojurescript / figwheel dev.
   (setq cider-cljs-lein-repl

modules/lang/emacs-lisp/config.el

@@ -115,8 +115,7 @@
 
 
 (def-package! overseer
-  :commands overseer-test
-  :init (set! :popup "*overseer*" :size 12))
+  :commands overseer-test)
 
 
 ;;

modules/lang/haskell/+intero.el

@@ -10,7 +10,6 @@
 
   (add-hook! 'intero-mode-hook #'(flycheck-mode eldoc-mode))
 
-  (set! :popup "^intero:backend:" :regex t :size 12)
   (set! :lookup 'haskell-mode :definition #'intero-goto-definition))
 
 

modules/lang/latex/config.el

@@ -33,7 +33,7 @@
           LaTeX-section-section
           LaTeX-section-label))
 
-  (set! :popup " output\\*$" :regexp t :size 15 :noselect t :autoclose t :autokill t)
+  (set! :popup " output\\*$" '((size . 15)))
   (map! :map LaTeX-mode-map "C-j" nil))
 
 

modules/lang/plantuml/config.el

@@ -4,7 +4,7 @@
   :mode "\\.p\\(lant\\)?uml$"
   :config
   (setq plantuml-jar-path (concat doom-etc-dir "plantuml.jar"))
-  (set! :popup "*PLANTUML Preview*" :size 25 :noselect t :autokill t)
+  (set! :popup "^\\*PLANTUML" '((size . 0.4)) '((select) (transient . 0)))
 
   (unless (executable-find "java")
     (warn "plantuml-mode: can't find java, preview disabled."))

modules/lang/python/config.el

@@ -78,7 +78,7 @@ environment variables."
         anaconda-mode-eldoc-as-single-line t)
   :config
   (add-hook 'anaconda-mode-hook #'anaconda-eldoc-mode)
-  (set! :popup "*anaconda-mode*" :size 10 :noselect t :autoclose t :autokill t)
+  (set! :popup "^\\*anaconda-mode" nil '((select)))
   (map! :map anaconda-mode-map :m "gd" #'anaconda-mode-find-definitions)
   (advice-add #'anaconda-mode-doc-buffer :after #'doom*anaconda-mode-doc-buffer))
 
@@ -113,7 +113,7 @@ environment variables."
   :init
   (associate! nose-mode :match "/test_.+\\.py$" :modes (python-mode))
   :config
-  (set! :popup "*nosetests*" :size 0.4 :noselect t)
+  (set! :popup "^\\*nosetests" '((size . 0.4)) '((select)))
   (set! :yas-minor-mode 'nose-mode)
   (map! :map nose-mode-map
         :localleader

modules/lang/rest/config.el

@@ -4,7 +4,7 @@
   :commands restclient-mode
   :mode ("\\.http$" . restclient-mode)
   :config
-  (set! :popup "*HTTP Response*" :size 30 :select t :noesc t :autokill t)
+  (set! :popup "^\\*HTTP Response" '((size . 0.4)) '((escape-quit . other)))
   (map! :mode restclient-mode
         :n [M-return] 'restclient-http-send-current
         :localleader