💥 Replace core-popup with new feature/popup module

This is a breaking change! Update your :popup settings. Old ones will
throw errors!

Doom's new popup management system casts off its shackles (hur hur) and
replaces them with the monster that is `display-buffer-alist`, and
window parameters.

However, this is highly experimental! Expect edge cases.  Particularly
with org-mode and magit (or anything that does its own window
management).

Relevant to #261, #263, #325

modules/feature/version-control/+git.el

@@ -24,7 +24,7 @@
       (git-gutter-mode +1)))
   (add-hook! (text-mode prog-mode conf-mode) #'+version-control|git-gutter-maybe)
   :config
-  (set! :popup "^\\*git-gutter.+\\*$" :regexp t :size 15 :noselect t)
+  (set! :popup "^\\*git-gutter" nil '((select)))
 
   ;; Update git-gutter on focus (in case I was using git externally)
   (add-hook 'focus-in-hook #'git-gutter:update-all-windows)

modules/feature/version-control/config.el

@@ -11,10 +11,8 @@
 
 
 (after! vc-annotate
-  (set! :popup
-    '("*vc-diff*" :size 15 :noselect t)
-    '("*vc-change-log*" :size 15)
-    '(vc-annotate-mode :same t))
+  (set! :popup "^\\vc-d" nil '((select)))     ; *vc-diff*
+  (set! :popup "^\\vc-c" nil '((select . t))) ; *vc-change-log*
 
   (set! :evil-state 'vc-annotate-mode 'normal)
   (set! :evil-state 'vc-git-log-view-mode 'normal))