💥 Replace core-popup with new feature/popup module

This is a breaking change! Update your :popup settings. Old ones will
throw errors!

Doom's new popup management system casts off its shackles (hur hur) and
replaces them with the monster that is `display-buffer-alist`, and
window parameters.

However, this is highly experimental! Expect edge cases.  Particularly
with org-mode and magit (or anything that does its own window
management).

Relevant to #261, #263, #325

modules/feature/evil/autoload/evil.el

@@ -32,14 +32,14 @@
 there and there is only one window, split in that direction and place this
 window there. If there are no windows and this isn't the only window, use
 evil-window-move-* (e.g. `evil-window-move-far-left')"
-  (when (doom-popup-p)
-    (doom/popup-raise))
-  (let* ((this-window (get-buffer-window))
+  (when (window-dedicated-p)
+    (user-error "Cannot swap a dedicated window"))
+  (let* ((this-window (selected-window))
          (this-buffer (current-buffer))
          (that-window (windmove-find-other-window direction nil this-window))
          (that-buffer (window-buffer that-window)))
     (when (or (minibufferp that-buffer)
-              (doom-popup-p that-window))
+              (window-dedicated-p this-window))
       (setq that-buffer nil that-window nil))
     (if (not (or that-window (one-window-p t)))
         (funcall (pcase direction

modules/feature/evil/config.el

@@ -42,9 +42,8 @@
   (add-hook 'doom-init-hook #'evil-mode)
   (evil-select-search-module 'evil-search-module 'evil-search)
 
-  (set! :popup
-    '("*evil-registers*" :size 0.3)
-    '("*Command Line*" :size 8))
+  (set! :popup "^\\*evil-registers" '((size . 0.3)))
+  (set! :popup "^\\*Command Line" '((size . 8)))
 
   ;; Don't interfere with localleader key
   (define-key evil-motion-state-map "\\" nil)