Remove core-popup coupling

New popup management system coming soon!

core/autoload/buffers.el

@@ -105,9 +105,7 @@ If DERIVED-P, test with `derived-mode-p', otherwise use `eq'."
 ;;;###autoload
 (defun doom-visible-windows (&optional window-list)
   "Return a list of the visible, non-popup windows."
-  (cl-loop for win in (or window-list (window-list))
+  (cl-remove-if #'window-at-side-p (or window-list (window-list))))
-           unless (doom-popup-p win)
-           collect win))
 
 ;;;###autoload
 (defun doom-visible-buffers (&optional buffer-list)

modules/feature/workspaces/autoload/workspaces.el

@@ -405,16 +405,15 @@ end of the workspace list."
   "Close the selected window. If it's the last window in the workspace, close
 the workspace and move to the next."
   (interactive)
-  (if (doom-popup-p)
+  (let ((delete-window-fn (if (featurep 'evil) #'evil-window-delete #'delete-window)))
-      (doom/popup-close)
+    (if (window-at-side-p)
+        (funcall delete-window-fn)
       (let ((current-persp-name (+workspace-current-name)))
         (cond ((or (+workspace--protected-p current-persp-name)
-                 (> (length (doom-visible-windows)) 1))
+                   (cdr (doom-visible-windows)))
-             (if (bound-and-true-p evil-mode)
+               (funcall delete-window-fn))
-                 (evil-window-delete)
+              ((cdr (+workspace-list-names))
-               (delete-window)))
+               (+workspace/delete current-persp-name)))))))
-            ((> (length (+workspace-list-names)) 1)
-             (+workspace/delete current-persp-name))))))
 
 ;;;###autoload
 (defun +workspace/close-workspace-or-frame ()

modules/lang/emacs-lisp/autoload.el

@@ -30,6 +30,6 @@ to a pop up buffer."
       (setq lines (count-lines (point-min) (point-max)))
       (goto-char (point-min))
       (if (> lines 1)
-          (doom-popup-buffer buf)
+          (pop-to-buffer buf t)
         (message "%s" (buffer-substring (point-min) (point-max)))
         (kill-buffer buf)))))