From 8c258c272d015920cb0ddb4e10796f5f5a2e7e72 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Mon, 11 Jan 2021 02:41:14 -0500 Subject: [PATCH] Update comments --- core/core-keybinds.el | 2 ++ core/core-ui.el | 13 ++++++------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/core/core-keybinds.el b/core/core-keybinds.el index 6d78c6db1..608b00ed9 100644 --- a/core/core-keybinds.el +++ b/core/core-keybinds.el @@ -46,6 +46,8 @@ and Emacs states, and for non-evil users.") (not (cl-position 'tab keys)) (not (cl-position 'kp-tab keys)) (display-graphic-p) + ;; Fall back if no keybind can be found, otherwise + ;; we've broken all pre-existing C-i keybinds. (let ((key (doom-lookup-key (vconcat (cl-subseq keys 0 -1) [C-i])))) diff --git a/core/core-ui.el b/core/core-ui.el index 212f95bc5..9587b0f9a 100644 --- a/core/core-ui.el +++ b/core/core-ui.el @@ -289,17 +289,16 @@ windows, switch to `doom-fallback-buffer'. Otherwise, delegate to original ;; where we resize windows too quickly. (setq window-resize-pixelwise nil) -;; We do this in early-init.el too, but in case the user is on Emacs 26 we do it -;; here too: disable tool and scrollbars, as Doom encourages keyboard-centric -;; workflows, so these are just clutter (the scrollbar also impacts -;; performance). +;; Disable tool, menu, and scrollbars. Doom is designed to be keyboard-centric, +;; so these are just clutter (the scrollbar also impacts performance). Whats +;; more, the menu bar exposes functionality that Doom doesn't endorse. (push '(menu-bar-lines . 0) default-frame-alist) (push '(tool-bar-lines . 0) default-frame-alist) (push '(vertical-scroll-bars) default-frame-alist) -;; These are disabled directly through their frame parameters, to avoid the -;; extra work their minor modes do, but we have to unset these variables -;; ourselves, otherwise users will have to cycle them twice to re-enable them. +;; These are disabled directly through their frame parameters to avoid the extra +;; work their minor modes do, but their variables must be unset too, otherwise +;; users will have to cycle them twice to re-enable them. (setq menu-bar-mode nil tool-bar-mode nil scroll-bar-mode nil)