From 8b3b39532d82261c5d4581bab421c4328ffa0db1 Mon Sep 17 00:00:00 2001 From: "Itai Y. Efrat" Date: Thu, 23 Sep 2021 14:41:39 +0300 Subject: [PATCH] fix(vertico): add +vertico/find-file-in stopgap Temporarily disable embark actions (and as a result, marginalia annotations) for +vertico/find-file-in and functions that use it, since because currently the embark actions don't inherit the intended default-directory, embark actions might run unintentional destructive operations if there are files with the same name in the default-directory and the directory +vertico/find-file-in is run on. Ref #5494 --- modules/completion/vertico/config.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/modules/completion/vertico/config.el b/modules/completion/vertico/config.el index 55dec4678..7c98ae1d0 100644 --- a/modules/completion/vertico/config.el +++ b/modules/completion/vertico/config.el @@ -192,10 +192,11 @@ overrides `completion-styles' during company completion sessions.") (add-hook 'marginalia-mode-hook #'all-the-icons-completion-marginalia-setup)) (advice-add #'marginalia--project-root :override #'doom-project-root) (pushnew! marginalia-command-categories - '(+default/find-file-under-here. file) - '(doom/find-file-in-emacsd . project-file) - '(doom/find-file-in-other-project . project-file) - '(doom/find-file-in-private-config . file) + ;; HACK temporarily disabled until #5494 is fixed + ;;'(+default/find-file-under-here. file) + ;;'(doom/find-file-in-emacsd . project-file) + ;;'(doom/find-file-in-other-project . project-file) + ;;'(doom/find-file-in-private-config . file) '(doom/describe-active-minor-mode . minor-mode) '(flycheck-error-list-set-filter . builtin) '(persp-switch-to-buffer . buffer)