refactor!(go): remove go-guru

BREAKING CHANGE: Removes go-guru from the Go module. It has been
deprecated upstream in favor of gopls, the official Go LSP server.

Close: #7995
Ref: golang/go/issues/65880
Co-authored-by: Henrik Lissner <git@henrik.io>
This commit is contained in:
pancho horrillo 2024-08-21 13:58:26 +02:00 committed by Henrik Lissner
parent c27387ce76
commit 879c0b06a4
4 changed files with 1 additions and 31 deletions

View file

@ -13,7 +13,6 @@ This module adds [[https://golang.org][Go]] support, with optional (but recommen
- REPL (~gore~) - REPL (~gore~)
- Syntax-checking (~flycheck~) - Syntax-checking (~flycheck~)
- Auto-formatting on save (~gofmt~) (requires [[doom-module::editor format +onsave]]) - Auto-formatting on save (~gofmt~) (requires [[doom-module::editor format +onsave]])
- Code navigation & refactoring (~go-guru~)
- [[../../editor/file-templates/templates/go-mode][File templates]] - [[../../editor/file-templates/templates/go-mode][File templates]]
- [[https://github.com/hlissner/doom-snippets/tree/master/go-mode][Snippets]] - [[https://github.com/hlissner/doom-snippets/tree/master/go-mode][Snippets]]
- Generate testing code (~go-gen-test~) - Generate testing code (~go-gen-test~)
@ -36,7 +35,6 @@ This module adds [[https://golang.org][Go]] support, with optional (but recommen
- [[doom-package:flycheck-golangci-lint]] if [[doom-module::checkers syntax]] - [[doom-package:flycheck-golangci-lint]] if [[doom-module::checkers syntax]]
- [[doom-package:go-eldoc]] - [[doom-package:go-eldoc]]
- [[doom-package:go-gen-test]] - [[doom-package:go-gen-test]]
- [[doom-package:go-guru]]
- [[doom-package:go-mode]] - [[doom-package:go-mode]]
- [[doom-package:gorepl-mode]] - [[doom-package:gorepl-mode]]
- [[doom-package:go-tag]] - [[doom-package:go-tag]]
@ -64,7 +62,6 @@ below.
- ~godoc~ (for documentation lookup) - ~godoc~ (for documentation lookup)
- ~gorename~ (for extra refactoring commands) - ~gorename~ (for extra refactoring commands)
- ~gore~ (for the REPL) - ~gore~ (for the REPL)
- ~guru~ (for code navigation & refactoring commands)
- ~goimports~ (/optional/: for auto-formatting code on save & fixing imports) - ~goimports~ (/optional/: for auto-formatting code on save & fixing imports)
- ~gotests~ (for generate test code) - ~gotests~ (for generate test code)
- ~gomodifytags~ (for manipulating tags) - ~gomodifytags~ (for manipulating tags)
@ -77,7 +74,6 @@ go install github.com/stamblerre/gocode@latest
go install golang.org/x/tools/cmd/godoc@latest go install golang.org/x/tools/cmd/godoc@latest
go install golang.org/x/tools/cmd/goimports@latest go install golang.org/x/tools/cmd/goimports@latest
go install golang.org/x/tools/cmd/gorename@latest go install golang.org/x/tools/cmd/gorename@latest
go install golang.org/x/tools/cmd/guru@latest
go install github.com/cweill/gotests/gotests@latest go install github.com/cweill/gotests/gotests@latest
go install github.com/fatih/gomodifytags@latest go install github.com/fatih/gomodifytags@latest
#+end_src #+end_src
@ -102,16 +98,6 @@ go install github.com/fatih/gomodifytags@latest
| [[kbd:][<localleader> b b]] | run ~$ go build~ | | [[kbd:][<localleader> b b]] | run ~$ go build~ |
| [[kbd:][<localleader> b r]] | run ~$ go run .~ | | [[kbd:][<localleader> b r]] | run ~$ go run .~ |
| [[kbd:][<localleader> h .]] | lookup symbol at point in godoc | | [[kbd:][<localleader> h .]] | lookup symbol at point in godoc |
| [[kbd:][<localleader> h d]] | describe symbol at point |
| [[kbd:][<localleader> h v]] | list free variables |
| [[kbd:][<localleader> h i]] | list implements relations for package types |
| [[kbd:][<localleader> h p]] | list peers for channel |
| [[kbd:][<localleader> h P]] | "what does this point to" |
| [[kbd:][<localleader> h r]] | list references to object |
| [[kbd:][<localleader> h e]] | which errors |
| [[kbd:][<localleader> h w]] | what query |
| [[kbd:][<localleader> h c]] | show callers of function at point |
| [[kbd:][<localleader> h C]] | show callees of function at point |
| [[kbd:][<localleader> t t]] | rerun last test | | [[kbd:][<localleader> t t]] | rerun last test |
| [[kbd:][<localleader> t a]] | run all tests in project | | [[kbd:][<localleader> t a]] | run all tests in project |
| [[kbd:][<localleader> t f]] | run all tests in current file | | [[kbd:][<localleader> t f]] | run all tests in current file |

View file

@ -7,8 +7,6 @@
(set-docsets! 'go-mode "Go") (set-docsets! 'go-mode "Go")
(set-repl-handler! 'go-mode #'gorepl-run) (set-repl-handler! 'go-mode #'gorepl-run)
(set-lookup-handlers! 'go-mode (set-lookup-handlers! 'go-mode
:definition #'go-guru-definition
:references #'go-guru-referrers
:documentation #'godoc-at-point) :documentation #'godoc-at-point)
(if (modulep! +lsp) (if (modulep! +lsp)
@ -25,17 +23,7 @@
"e" #'+go/play-buffer-or-region "e" #'+go/play-buffer-or-region
"i" #'go-goto-imports ; Go to imports "i" #'go-goto-imports ; Go to imports
(:prefix ("h" . "help") (:prefix ("h" . "help")
"." #'godoc-at-point ; Lookup in godoc "." #'godoc-at-point) ; Lookup in godoc
"d" #'go-guru-describe ; Describe this
"v" #'go-guru-freevars ; List free variables
"i" #'go-guru-implements ; Implements relations for package types
"p" #'go-guru-peers ; List peers for channel
"P" #'go-guru-pointsto ; What does this point to
"r" #'go-guru-referrers ; List references to object
"e" #'go-guru-whicherrs ; Which errors
"w" #'go-guru-what ; What query
"c" #'go-guru-callers ; Show callers of this function
"C" #'go-guru-callees) ; Show callees of this function
(:prefix ("ri" . "imports") (:prefix ("ri" . "imports")
"a" #'go-import-add "a" #'go-import-add
"r" #'go-remove-unused-imports) "r" #'go-remove-unused-imports)

View file

@ -9,9 +9,6 @@
(modulep! :tools tree-sitter)) (modulep! :tools tree-sitter))
"This module requires (:tools tree-sitter)") "This module requires (:tools tree-sitter)")
(unless (executable-find "guru")
(warn! "Couldn't find guru. Refactoring commands (go-guru-*) won't work"))
(unless (executable-find "gore") (unless (executable-find "gore")
(warn! "Couldn't find gore. REPL will not work")) (warn! "Couldn't find gore. REPL will not work"))

View file

@ -2,7 +2,6 @@
;;; lang/go/packages.el ;;; lang/go/packages.el
(package! go-eldoc :pin "cbbd2ea1e94a36004432a9ac61414cb5a95a39bd") (package! go-eldoc :pin "cbbd2ea1e94a36004432a9ac61414cb5a95a39bd")
(package! go-guru :pin "636d36e37a0d2b6adb2e12d802ff4794ccbba336")
(package! go-mode :pin "636d36e37a0d2b6adb2e12d802ff4794ccbba336") (package! go-mode :pin "636d36e37a0d2b6adb2e12d802ff4794ccbba336")
(package! gorepl-mode :pin "6a73bf352e8d893f89cad36c958c4db2b5e35e07") (package! gorepl-mode :pin "6a73bf352e8d893f89cad36c958c4db2b5e35e07")
(package! go-tag :pin "33f2059551d5298ca228d90f525b99d1a8d70364") (package! go-tag :pin "33f2059551d5298ca228d90f525b99d1a8d70364")