Fixes from PR feedback

This contains fixes suggested by Henrik as feedback from the initial PR,
including updating and correcting the Eshell module README, and few
tweaks to the module configuration, and properly pinning
eshell-did-you-mean.
This commit is contained in:
Steven vanZyl 2020-04-28 09:35:06 -04:00
parent 73de701073
commit 85cf7a794b
4 changed files with 17 additions and 12 deletions

View file

@ -82,10 +82,6 @@ You should use `set-eshell-alias!' to change this.")
;; Enable autopairing in eshell
(add-hook 'eshell-mode-hook #'smartparens-mode)
;; Comapny completion integration
(when (featurep! :completion company)
(add-hook 'eshell-mode-hook #'company-mode))
;; Persp-mode/workspaces integration
(when (featurep! :ui workspaces)
(add-hook 'persp-activated-functions #'+eshell-switch-workspace-fn)
@ -157,8 +153,6 @@ You should use `set-eshell-alias!' to change this.")
[remap evil-delete-back-to-indentation] #'eshell-kill-input
[remap evil-window-split] #'+eshell/split-below
[remap evil-window-vsplit] #'+eshell/split-right
;; Local-leader keybindings
(:localleader
"b" #'eshell-insert-buffer-name
"e" #'eshell-insert-envvar
@ -196,4 +190,6 @@ You should use `set-eshell-alias!' to change this.")
;; Active eshell-did-you-mean using its setup function which provides
;; its own hooks.
(eshell-did-you-mean-setup)
(use-package! eshell-did-you-mean
:after eshell
:config (eshell-did-you-mean-setup))