lang/javascript: refactor company/lookup config; bring back xref-js2

modules/lang/javascript/config.el

@@ -80,12 +80,20 @@
       (tide-setup)))
   (add-hook 'web-mode-hook #'+javascript|init-tide-in-web-mode)
   :config
-  (set! :company '(js2-mode typescript-mode) 'company-tide)
+  (add-hook 'tide-mode-hook #'eldoc-mode)
-  (set! :lookup '(js2-mode rjsx-mode typescript-mode)
+
+  ;; code completion
+  (after! company
+    ;; tide affects the global `company-backends', undo this so doom can handle
+    ;; it buffer-locally
+    (setq-default company-backends (delq 'company-tide (default-value 'company-backends))))
+  (set! :company-backends 'tide-mode 'company-tide)
+
+  ;; navigation
+  (set! :lookup 'tide-mode
     :definition #'tide-jump-to-definition
     :references #'tide-references
     :documentation #'tide-documentation-at-point)
-  (add-hook 'tide-mode-hook #'eldoc-mode)
 
   ;; resolve to `doom-project-root' if `tide-project-root' fails
   (advice-add #'tide-project-root :override #'+javascript*tide-project-root)
@@ -131,6 +139,12 @@
         :n "r" #'+javascript/refactor-menu))
 
 
+(def-package! xref-js2
+  :when (featurep! :feature lookup)
+  :commands xref-js2-xref-backend
+  :init (set! :lookup 'js2-mode :xref-backend #'xref-js2-xref-backend))
+
+
 (def-package! nodejs-repl
   :commands nodejs-repl
   :init

modules/lang/javascript/packages.el

@@ -14,3 +14,6 @@
 (package! typescript-mode)
 (package! web-beautify)
 
+(when (featurep! :feature lookup)
+  (package! xref-js2))
+