def-advice!->defadvice! & conform to new advice conventions

This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.

modules/lang/haskell/+dante.el

@@ -19,15 +19,16 @@
 
   (set-company-backend! 'dante-mode #'dante-company)
 
-  (defun +haskell*restore-modified-state (orig-fn &rest args)
-    "Dante quietly saves the current buffer (without triggering save hooks) before
+  (defadvice! +haskell--restore-modified-state-a (orig-fn &rest args)
+    "Marks the buffer as falsely modified.
+Dante quietly saves the current buffer (without triggering save hooks) before
 invoking flycheck, unexpectedly leaving the buffer in an unmodified state. This
 is annoying if we depend on save hooks to do work on the buffer (like
-reformatting), so we restore a (false) modified state."
+reformatting)."
+    :around #'dante-async-load-current-buffer
     (let ((modified-p (buffer-modified-p)))
       (apply orig-fn args)
       (if modified-p (set-buffer-modified-p t))))
-  (advice-add #'dante-async-load-current-buffer :around #'+haskell*restore-modified-state)
 
   (when (featurep 'evil)
     (add-hook 'dante-mode-hook #'evil-normalize-keymaps))