def-advice!->defadvice! & conform to new advice conventions

This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.

modules/editor/fold/config.el

@@ -28,7 +28,7 @@
         ;; Nicer code-folding overlays (with fringe indicators)
         hs-set-up-overlay #'+fold-hideshow-set-up-overlay-fn)
 
-  (def-advice! +fold-hideshow-ensure-mode-a (&rest _)
+  (defadvice! +fold--hideshow-ensure-mode-a (&rest _)
     "Ensure `hs-minor-mode' is enabled."
     :before '(hs-toggle-hiding hs-hide-block hs-hide-level hs-show-all hs-hide-all)
     (unless (bound-and-true-p hs-minor-mode)

modules/editor/multiple-cursors/config.el

@@ -107,7 +107,7 @@
 
     ;; When running edit-lines, point will return (position + 1) as a result of
     ;; how evil deals with regions
-    (def-advice! +multiple-cursors-adjust-mark-for-evil-a (&rest _)
+    (defadvice! +multiple--cursors-adjust-mark-for-evil-a (&rest _)
       :before #'mc/edit-lines
       (when (and (bound-and-true-p evil-mode)
                  (not (memq evil-state '(insert emacs))))

modules/editor/objed/config.el

@@ -10,14 +10,14 @@
 
   (defvar +objed--extra-face-remaps nil)
 
-  (def-advice! +objed-add-face-remaps-a (&rest _)
+  (defadvice! +objed--add-face-remaps-a (&rest _)
     "Add extra face remaps when objed activates."
     :after 'objed--init
     (when (memq 'objed-hl (assq 'hl-line face-remapping-alist))
       (push (face-remap-add-relative 'solaire-hl-line-face 'objed-hl)
             +objed--extra-face-remaps)))
 
-  (def-advice! +objed-remove-face-remaps-a (&rest _)
+  (defadvice! +objed--remove-face-remaps-a (&rest _)
     "Remove extra face remaps when objed de-activates."
     :after 'objed--reset
     (unless (memq 'objed-hl (assq 'hl-line face-remapping-alist))

modules/editor/snippets/config.el

@@ -75,7 +75,7 @@
   :defer t
   :init (setq aya-persist-snippets-dir (concat doom-etc-dir "auto-snippets/"))
   :config
-  (def-advice! +snippets-inhibit-yas-global-mode (orig-fn &rest args)
+  (defadvice! +snippets--inhibit-yas-global-mode (orig-fn &rest args)
     "auto-yasnippet enables `yas-global-mode'. This is obnoxious for folks like
 us who use yas-minor-mode and enable yasnippet more selectively. This advice
 swaps `yas-global-mode' with `yas-minor-mode'."