def-advice!->defadvice! & conform to new advice conventions

This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.

modules/completion/company/config.el

@@ -27,7 +27,7 @@
     ;; Allow users to switch between backends on the fly. E.g. C-x C-s followed
     ;; by C-x C-n, will switch from `company-yasnippet' to
     ;; `company-dabbrev-code'.
-    (def-advice! +company-abort-previous-a (&rest _)
+    (defadvice! +company--abort-previous-a (&rest _)
       :before #'company-begin-backend
       (company-abort)))
 

modules/completion/helm/config.el

@@ -83,7 +83,7 @@ be negative.")
   :init
   (when (and EMACS26+ (featurep! +childframe))
     (setq helm-display-function #'+helm-posframe-display-fn)
-    (def-advice! +helm--fix-get-font-height-a (orig-fn position)
+    (defadvice! +helm--fix-get-font-height-a (orig-fn position)
       "Fix \"Specified window is not displaying the current buffer\" error."
       :around #'posframe--get-font-height
       (ignore-errors (funcall orig-fn position))))

modules/completion/ido/config.el

@@ -28,7 +28,7 @@
                 (insert "~/")
               (call-interactively #'self-insert-command))))
 
-  (def-advice! +ido-sort-mtime-a ()
+  (defadvice! +ido--sort-mtime-a ()
     "Sort ido filelist by mtime instead of alphabetically."
     :override #'ido-sort-mtime
     (setq ido-temp-list

modules/completion/ivy/config.el

@@ -93,7 +93,7 @@ immediately runs it on the current candidate (ending the ivy session)."
   (after! yasnippet
     (add-to-list 'yas-prompt-functions #'+ivy-yas-prompt nil #'eq))
 
-  (def-advice! +ivy--inhibit-ivy-in-evil-ex-a (orig-fn &rest args)
+  (defadvice! +ivy--inhibit-in-evil-ex-a (orig-fn &rest args)
     "`ivy-completion-in-region' struggles with completing certain
 evil-ex-specific constructs, so we disable it solely in evil-ex."
     :around #'evil-ex