General refactor for consistency & idempotency

Also updated comments

modules/lang/clojure/config.el

@@ -14,10 +14,10 @@
   :after clojure-mode
   :config
   ;; setup some extra namespace auto completion for great awesome
-  (nconc cljr-magic-require-namespaces
-         '(("re-frame" . "re-frame.core")
-           ("reagent"  . "reagent.core")
-           ("str"      . "clojure.string"))))
+  (dolist (ns '(("re-frame" . "re-frame.core")
+                ("reagent"  . "reagent.core")
+                ("str"      . "clojure.string")))
+    (map-put cljr-magic-require-namespaces (car ns) (cdr ns))))
 
 
 (def-package! cider

modules/lang/crystal/config.el

@@ -14,6 +14,7 @@
 
 
 (def-package! flycheck-crystal
+  :when (featurep! :feature syntax-checker)
   :after crystal-mode
   :config (add-hook 'crystal-mode-hook #'flycheck-mode))
 

modules/lang/elixir/config.el

@@ -32,7 +32,8 @@
   :when (featurep! :completion company)
   :after elixir-mode
   :config
-  ;; Let Doom handle this
+  ;; Alchemist doesn't use hook symbols to add these backends, so we have to use
+  ;; the entire closure to get rid of it.
   (let ((fn (byte-compile (lambda () (add-to-list (make-local-variable 'company-backends) 'alchemist-company)))))
     (remove-hook 'alchemist-mode-hook fn)
     (remove-hook 'alchemist-iex-mode-hook fn))

modules/lang/emacs-lisp/config.el

@@ -57,9 +57,7 @@
   (defun +emacs-lisp|init-flycheck ()
     "Initialize flycheck-mode if not in emacs.d."
     (when (and buffer-file-name
-               (not (cl-loop for dir in (append (list doom-emacs-dir)
-                                                doom-modules-dirs
-                                                doom-psuedo-module-dirs)
+               (not (cl-loop for dir in (list doom-emacs-dir doom-private-dir)
                              if (file-in-directory-p buffer-file-name dir)
                              return t)))
       (flycheck-mode +1))))

modules/lang/ess/config.el

@@ -31,7 +31,7 @@
          ("\\.[Jj][Mm][Dd]\\'" . ess-jags-mode))
   :init
   (unless (featurep! :lang julia)
-    (push (cons "\\.jl\\'" 'ess-julia-mode) auto-mode-alist))
+    (map-put auto-mode-alist "\\.jl\'" 'ess-julia-mode))
   :config
   (add-hook 'ess-mode-hook #'doom|enable-line-numbers)
   (setq ess-offset-continued 'straight

modules/lang/markdown/config.el

@@ -15,10 +15,11 @@
         markdown-hide-urls nil) ; trigger with `markdown-toggle-url-hiding'
 
   :config
+  (defun +markdown|set-fill-column-and-line-spacing ()
+    (setq-local line-spacing 2)
+    (setq-local fill-column 80))
+  (add-hook 'markdown-mode-hook #'+markdown|set-fill-column-and-line-spacing)
   (add-hook 'markdown-mode-hook #'auto-fill-mode)
-  (setq-hook! 'markdown-mode-hook
-    line-spacing 2
-    fill-column 80)
 
   (map! (:map markdown-mode-map
           [remap find-file-at-point] #'markdown-follow-thing-at-point

modules/lang/python/config.el

@@ -102,7 +102,6 @@ environment variables."
   :after anaconda-mode
   :config
   (map! :map anaconda-mode-map
-        :n "gf" nil
         :localleader
         :prefix "f"
         :nv "d" #'anaconda-mode-find-definitions

modules/lang/web/+html.el

@@ -82,7 +82,6 @@
 
         "M-/" #'web-mode-comment-or-uncomment
         :i  "SPC" #'self-insert-command
-        :n  "M-r" #'doom/web-refresh-browser
         :n  "za"  #'web-mode-fold-or-unfold
         :nv "]a"  #'web-mode-attribute-next
         :nv "[a"  #'web-mode-attribute-previous