From 7fbaf2ced1a44457499c7f00d4099935a995801f Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Fri, 12 May 2017 12:14:17 +0200 Subject: [PATCH] General cleanup & refector; update TODO.org --- TODO.org | 23 ++++++++++++++++------- core/autoload/buffers.el | 3 +++ core/autoload/popups.el | 3 +-- core/core-popups.el | 3 ++- modules/ui/doom/config.el | 2 +- 5 files changed, 23 insertions(+), 11 deletions(-) diff --git a/TODO.org b/TODO.org index e9fcbadcc..b6d3598cd 100644 --- a/TODO.org +++ b/TODO.org @@ -5,7 +5,7 @@ + [-] Work-in-progress + [X] Complete -** Planned [6/80] +** Planned [6/83] + [0/10] Potential plugins + [ ] [[https://github.com/emacs-lsp/lsp-mode][lsp-mode]]: client for MS Language Server Protocol, keep an eye on this + [ ] lang/javascript: [[https://github.com/codesuki/add-node-modules-path][add-node-modules-path]] (adds node_modules to ~exec-path~) @@ -89,18 +89,27 @@ + [ ] rss + [ ] twitter + [ ] present ++ [ ] completion/ivy: flexible column width for ~+ivy/tasks~ ++ [ ] Extend ~evil-escape~ to ~evil-multiedit-insert-state~ ++ [ ] ui/doom (nav-flash): don't flash when activating evil-multiedit or in eshell/term buffers + [ ] Write ~describe-setting~ for ~def-setting!~ definitions. -+ [ ] lang/org: restore cursor to sane location after prepending/appending new table cells. -+ [ ] lang/org: don't move cursor when realigning tables when exiting insert state. -+ [ ] lang/org: typing certain characters and keys while in a table causes the cell to shrink (like smartparens pairs and keys not bound to self-insert-command) -+ [ ] Fix invisible buffer-info in modeline for terminal Emacs ++ [ ] lang/org: fix janky cursor positioning when manipulating table cells ++ [ ] lang/org: don't move cursor when realigning tables ++ [ ] lang/org: certain characters/keys, when typed in a table, cause the cell to shrink (smartparens pairs & non-self-insert-command, likely) ++ [ ] Fix invisible buffer-info segment in modeline for terminal Emacs + [ ] tools/upload: add ~+upload/open-remote-file~ command to open current file on the remote (with TRAMP) -+ [ ] Make ~doom-visual-bell~ more flexible by basing it's bg color off a face ++ [ ] Generalize ~doom-visual-bell~ by basing its background off a face -** 2.0.2 [58/61] +** 2.0.2 [63/66] + [ ] Update screenshots + [ ] send-to-REPL workflow: does it still work? (see ~:repl~ & ~+eval/repl-send-region~) + [ ] Fix ~0/0~ displaying in modeline (caused by leftover anzu state) ++ [X] completion/ivy: restore ag searching (for compressed files) + Now ~:ag~, ~:rg~, ~:agcwd~ and ~:rgcwd~ ++ [X] ~add-transient-hook!~: add support for appending ++ [X] lang/org: fix org-checkbox-statistics-(todo|done) not respecting underlying faces ++ [X] Make ~:cleanup~ support a BANG modifier (to span workspaces) ++ [X] Rewrote ~:mv~ and ~:rm~ + [X] completion/ivy: fix ~+ivy:find-file~ -- loss of functionality with coerced literal searches (better to escape regex rather than pass -F to rg) + [X] completion/ivy: refactor ~def-counsel-action!~ +into a setting (~def-setting!~)+ Refactored into ~ivy-do-action!~ macro instead diff --git a/core/autoload/buffers.el b/core/autoload/buffers.el index e00295f7a..b708ef679 100644 --- a/core/autoload/buffers.el +++ b/core/autoload/buffers.el @@ -153,6 +153,7 @@ See `doom-real-buffer-p' for what 'real' means." (let* ((buffer (or buffer (current-buffer))) (buffer-win (get-buffer-window buffer)) (only-buffer-window-p (= 1 (length (get-buffer-window-list buffer nil t))))) + ;; deal with unsaved buffers (when (and only-buffer-window-p (buffer-file-name buffer) (buffer-modified-p buffer)) @@ -161,10 +162,12 @@ See `doom-real-buffer-p' for what 'real' means." (yes-or-no-p "Buffer is unsaved, save it?")) (save-buffer) (set-buffer-modified-p nil)))) + ;; deal with dedicated windows (if (window-dedicated-p buffer-win) (unless (window--delete buffer-win t t) (split-window buffer-win) (window--delete buffer-win t t)) + ;; cycle to a real buffer (doom--cycle-real-buffers -1) (when buffer-win (unrecord-window-buffer buffer-win buffer)) diff --git a/core/autoload/popups.el b/core/autoload/popups.el index 23742d568..0c6073ec0 100644 --- a/core/autoload/popups.el +++ b/core/autoload/popups.el @@ -18,8 +18,7 @@ current window if omitted." (declare (indent defun)) (unless (bufferp buffer) (error "%s is not a valid buffer" buffer)) - (when (and plist (not (plist-member plist :align))) - (plist-put plist :align t)) + (setq plist (doom*shackle-always-align plist)) (shackle-display-buffer buffer nil (or plist (shackle-match buffer)))) diff --git a/core/core-popups.el b/core/core-popups.el index c96209d97..a1560584d 100644 --- a/core/core-popups.el +++ b/core/core-popups.el @@ -27,7 +27,8 @@ (defvar-local doom-popup-rules nil "The shackle rule that caused this buffer to be recognized as a popup.") -(defvar doom-popup-window-parameters '(:noesc :modeline :autokill :autoclose) +(defvar doom-popup-window-parameters + '(:noesc :modeline :autokill :autoclose) "A list of window parameters that are set (and cleared) when `doom-popup-mode is enabled/disabled.'") diff --git a/modules/ui/doom/config.el b/modules/ui/doom/config.el index 7653e1a07..8b4395269 100644 --- a/modules/ui/doom/config.el +++ b/modules/ui/doom/config.el @@ -1,7 +1,7 @@ ;;; ui/doom/config.el (defvar +doom-theme 'doom-one - "The color theme currently in use.") + "The color theme to use.") (defvar +doom-font (font-spec :family "Fira Mono" :size 12)