From 769cf850c955d9886b533efb8e098f2f4c063c70 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Mon, 20 Mar 2017 04:24:10 -0400 Subject: [PATCH] General comment + README cleanup --- core/core-os.el | 9 ++++----- modules/lang/go/config.el | 4 ---- modules/lang/javascript/+screeps.el | 2 ++ modules/private/README.md | 8 ++------ 4 files changed, 8 insertions(+), 15 deletions(-) diff --git a/core/core-os.el b/core/core-os.el index 728e46807..246dadcce 100644 --- a/core/core-os.el +++ b/core/core-os.el @@ -24,12 +24,11 @@ ;; Don't open files from the workspace in a new frame ns-pop-up-frames nil) - ;; A known problem with GUI Emacs on MacOS: it runs in an isolated - ;; environment, so envvars will be wrong. That includes the PATH Emacs - ;; picks up. `exec-path-from-shell' fixes this, and its result is cached. - ;; Run `doom/clean-cache' to regenerate exec-path if PATH changes. (cond ((display-graphic-p) - ;; `exec-path-from-shell' is slow, so bring out the cache + ;; A known problem with GUI Emacs on MacOS: it runs in an isolated + ;; environment, so envvars will be wrong. That includes the PATH + ;; Emacs picks up. `exec-path-from-shell' fixes this. This is slow + ;; and benefits greatly from compilation. (setq exec-path (or (eval-when-compile (when (require 'exec-path-from-shell nil t) diff --git a/modules/lang/go/config.el b/modules/lang/go/config.el index 0e09e9226..864c46523 100644 --- a/modules/lang/go/config.el +++ b/modules/lang/go/config.el @@ -1,9 +1,5 @@ ;;; lang/go/config.el -;; requires gocode (completion), gore (repl) and a valid $GOPATH -;; go get -u github.com/nsf/gocode -;; go get -u github.com/motemen/gore - (def-package! go-mode :mode "\\.go$" :interpreter "go" diff --git a/modules/lang/javascript/+screeps.el b/modules/lang/javascript/+screeps.el index 291c35691..10e578d26 100644 --- a/modules/lang/javascript/+screeps.el +++ b/modules/lang/javascript/+screeps.el @@ -1,5 +1,7 @@ ;;; lang/javascript/+screeps.el +;; TODO Constants may be out-of-date + (defconst screeps-objects '("ConstructionSite" "Creep" "Flag" "Game" "Memory" "Mineral" "Nuke" "OwnedStructure" "PathFinder" "RawMemory" "Resource" "Room" diff --git a/modules/private/README.md b/modules/private/README.md index 89b0d9ed6..58f332e67 100644 --- a/modules/private/README.md +++ b/modules/private/README.md @@ -3,9 +3,5 @@ Modules here are ignored by git and should contain personal settings you don't want DOOM updates to interfere with (if that matters to you). -I include mine as a reference. However, keep in mind that it is fiercely -evil-mode-oriented. I apologize to non-evil users, but you will likely want to -rewrite +bindings.el entirely and delete +commands.el. - -Fortunately, besides disabled the evil module, that should be all you need to do -to get an evil-less DOOM Emacs. +I include mine as a reference. However, a warning to non-evil users: my module +is fiercely evil-mode-oriented.