Minor refactors across the board

modules/config/default/+evil-bindings.el

@@ -17,7 +17,7 @@
         "M-;" #'eval-expression
         "A-;" #'eval-expression)
 
-      ;; Smart tab
+      ;; Smart tab, these will only work in GUI Emacs
       :i [tab] (general-predicate-dispatch nil ; fall back to nearest keymap
                  (and (featurep! :editor snippets)
                       (bound-and-true-p yas-minor-mode)

modules/emacs/dired/config.el

@@ -34,9 +34,6 @@
       (let (buffer-read-only)
         (forward-line 2) ;; beyond dir. header
         (sort-regexp-fields t "^.*$" "[ ]*." (point) (point-max))))
-    (and (featurep 'xemacs)
-         (fboundp 'dired-insert-set-properties)
-         (dired-insert-set-properties (point-min) (point-max)))
     (set-buffer-modified-p nil))
   (add-hook 'dired-after-readin-hook #'+dired|sort-directories-first)
 

modules/lang/emacs-lisp/config.el

@@ -52,8 +52,8 @@ This marks a foldable marker for `outline-minor-mode' in elisp buffers.")
        ;; initialization
        +emacs-lisp|extend-imenu))
 
-  ;; Flycheck produces a *lot* of false positives in emacs configs, so disable
-  ;; it when you're editing them
+  ;; Flycheck's two emacs-lisp checkers produce a *lot* of false positives in
+  ;; emacs configs, so disable it when you're editing them
   (add-hook 'flycheck-mode-hook #'+emacs-lisp|disable-flycheck-maybe)
 
   ;; Special fontification for elisp

modules/ui/doom-dashboard/config.el

@@ -137,6 +137,7 @@ PLIST can have the following properties:
   "Major mode for the DOOM dashboard buffer."
   :syntax-table nil
   :abbrev-table nil
+  (buffer-disable-undo)
   (setq truncate-lines t)
   (setq-local whitespace-style nil)
   (setq-local show-trailing-whitespace nil)
@@ -265,7 +266,9 @@ project (which may be different across perspective)."
   (when (bound-and-true-p persp-mode)
     (set-persp-parameter
      'last-project-root (doom-project-root)
-     (if (perspective-p persp) persp (get-current-persp)))))
+     (if (persp-p persp)
+         persp
+       (get-current-persp)))))
 
 
 ;;
@@ -325,11 +328,9 @@ controlled by `+doom-dashboard-pwd-policy'."
           ((null lastcwd)
            default-directory)
           ((eq policy 'last-project)
-           (let ((cwd default-directory)
-                 (default-directory lastcwd))
-             (if (doom-project-p)
-                 (doom-project-root)
-               cwd)))
+           (let ((cwd default-directory))
+             (or (doom-project-root lastcwd)
+                 cwd)))
           ((eq policy 'last)
            lastcwd)
           ((warn "`+doom-dashboard-pwd-policy' has an invalid value of '%s'"