Appease byte-compiler senpai

core/core-packages.el

@@ -592,10 +592,11 @@ If ONLY-RECOMPILE-P is non-nil, only recompile out-of-date files."
                              else if (file-exists-p path)
                                collect path)))
       (dolist (file el-files)
-        (when (or (not only-recompile-p)
+        (when (and (not (string-match-p "/test/.+\\.el$" file))
-                  (let ((elc-file (byte-compile-dest-file file)))
+                   (or (not only-recompile-p)
-                    (and (file-exists-p elc-file)
+                       (let ((elc-file (byte-compile-dest-file file)))
-                         (file-newer-than-file-p file elc-file))))
+                         (and (file-exists-p elc-file)
+                              (file-newer-than-file-p file elc-file)))))
           (let ((result (byte-compile-file file))
                 (short-name (file-relative-name file doom-emacs-dir)))
             (cl-incf

modules/app/email/autoload/evil.el

@@ -5,8 +5,8 @@
   "Mark all messages within the current selection in mu4e's header view. Uses
 `this-command-keys' to see what flag you mean."
   (interactive)
-  (let* ((beg (or (and (region-active-p) evil-visual-beginning) (line-beginning-position)))
+  (let* ((beg (or beg (and (region-active-p) evil-visual-beginning) (line-beginning-position)))
-         (end (or (and (region-active-p) evil-visual-end) (line-end-position)))
+         (end (or end (and (region-active-p) evil-visual-end) (line-end-position)))
          (key (this-command-keys))
          (command
           (car (cl-find-if (lambda (mark) (equal (car (plist-get (cdr mark) :char)) key))

modules/app/irc/config.el

@@ -28,6 +28,10 @@ playback.")
 
 (defvar +irc--defer-timer nil)
 
+(defsubst +irc--pad (left right)
+  (format (format "%%%ds | %%s" +irc-left-padding)
+          (concat "*** " left) right))
+
 
 ;;
 ;; Plugins
@@ -37,10 +41,6 @@ playback.")
   :commands (circe circe-server-buffers)
   :init (setq circe-network-defaults nil)
   :config
-  (defsubst +irc--pad (left right)
-    (format (format "%%%ds | %%s" +irc-left-padding)
-            (concat "*** " left) right))
-
   (setq circe-default-quit-message nil
         circe-default-part-message nil
         circe-use-cycle-completion t

modules/app/twitter/autoload.el

@@ -5,7 +5,7 @@
   (interactive)
   (+workspace-switch "*Twitter*" t)
   (delete-other-windows)
-  (condition-case ex
+  (condition-case _ex
       (progn
         (call-interactively #'twit)
         (unless (get-buffer (car twittering-initial-timeline-spec-string))

modules/feature/debug/config.el

@@ -20,7 +20,7 @@
   ;; TODO Find a more elegant solution
   ;; FIXME Causes realgud:cmd-* to focus popup on every invocation
   (defun +debug*realgud-run-process
-      (debugger-name script-filename cmd-args minibuffer-history &optional no-reset)
+      (debugger-name script-filename cmd-args minibuffer-history-var &optional no-reset)
     (let* ((cmd-buf (apply #'realgud-exec-shell debugger-name script-filename
                            (car cmd-args) no-reset (cdr cmd-args)))
            (process (get-buffer-process cmd-buf)))
@@ -36,8 +36,8 @@
                  (let* ((info realgud-cmdbuf-info)
                         (cmd-args (realgud-cmdbuf-info-cmd-args info))
                         (cmd-str  (mapconcat #'identity cmd-args " ")))
-                   (set minibuffer-history
+                   (set minibuffer-history-var
-                        (list-utils-uniq (cons cmd-str (eval minibuffer-history))))))))
+                        (list-utils-uniq (cons cmd-str (eval minibuffer-history-var))))))))
             (t
              (if cmd-buf (switch-to-buffer cmd-buf))
              (message "Error running command: %s" (mapconcat #'identity cmd-args " "))))

modules/feature/evil/config.el

@@ -170,12 +170,7 @@ across windows."
 
 (def-package! evil-easymotion
   :after evil-snipe
-  :config
+  :commands evilem-create)
-  (defvar +evil--snipe-repeat-fn
-    (evilem-create #'evil-snipe-repeat
-                   :bind ((evil-snipe-scope 'whole-buffer)
-                          (evil-snipe-enable-highlight)
-                          (evil-snipe-enable-incremental-highlight)))))
 
 
 (def-package! evil-embrace

modules/feature/jump/autoload/jump.el

@@ -6,7 +6,7 @@
 (defun +jump-to (prop identifier &optional other-window)
   (with-selected-window
       (if other-window
-          (save-excursion (other-window) (selected-window))
+          (save-excursion (other-window 1) (selected-window))
         (selected-window))
     (let ((fn (plist-get +jump-current-functions prop)))
       (if (commandp fn)

modules/feature/version-control/autoload.el

@@ -10,6 +10,7 @@
                 (git-link--remote-dir remote))
       (error  "Remote `%s' is unknown or contains an unsupported URL" remote))))
 
+(defvar git-link-open-in-browser)
 ;;;###autoload
 (defun +vcs/git-browse ()
   "Open the website for the current version controlled file. Fallback to

modules/feature/workspaces/test/autoload-workspaces.el

@@ -1,4 +1,5 @@
-;;; feature/workspaces/test/autoload-workspaces.el -*- lexical-binding: t; -*-
+;; -*- no-byte-compile: t; -*-
+;;; feature/workspaces/test/autoload-workspaces.el
 
 (require! :feature workspaces)
 

modules/lang/markdown/config.el

@@ -52,8 +52,7 @@
           (:prefix "i"
             :nv "t" #'markdown-toc-generate-toc
             :nv "i" #'markdown-insert-image
-            :nv "l" #'markdown-insert-inline-link-dwim
+            :nv "l" #'markdown-insert-link))))
-            :nv "L" #'markdown-insert-reference-link-dwim))))
 
 
 (def-package! markdown-toc

modules/lang/web/test/autoload-html.el

@@ -1,4 +1,5 @@
-;;; lang/web/test/autoload-html.el -*- lexical-binding: t; -*-
+;; -*- no-byte-compile: t; -*-
+;;; lang/web/test/autoload-html.el
 
 (def-test! encode-entities
   (should (equal (+web-encode-entities "Hello world")

modules/private/hlissner/+bindings.el

@@ -440,7 +440,11 @@
    ;; Binding to switch to evil-easymotion/avy after a snipe
    :map evil-snipe-parent-transient-map
    "C-;" (λ! (require 'evil-easymotion)
-             (call-interactively +evil--snipe-repeat-fn)))
+             (call-interactively
+              (evilem-create #'evil-snipe-repeat
+                             :bind ((evil-snipe-scope 'whole-buffer)
+                                    (evil-snipe-enable-highlight)
+                                    (evil-snipe-enable-incremental-highlight))))))
 
  ;; evil-surround
  :v  "S"  #'evil-surround-region