💥 Change set-popup-rule! usage

Now accepts a flat plist of all its former parameters, including new
:parameters and :actions properties to increase your control over the
fate of your windows.

The old usage of set-popup-rule! is deprecated and may not work right!

The :ui popup module has also seen a major refactor to improve
efficiency and load times.

Sorry! This is the last "big" change before 2.1!

modules/tools/ein/config.el

@@ -18,12 +18,8 @@
 
   (set-popup-rules!
    '(("\\*ein: .*" :ignore t)
-     ("\\*ein:tb .*"
-      ((side . bottom) (size . 0.3))
-      ((quit . t) (transient) (select)))
-     ("\\*ein:notebooklist *"
-      ((side . left) (size . 50))
-      ((select)))))
+     ("\\*ein:tb .*" :side 'bottom :size 0.3 :quit t :ttl nil :select nil)
+     ("\\*ein:notebooklist *" :side 'left :size 50 :select nil)))
 
   (when (featurep! :completion company)
     ;; Code completion with company

modules/tools/magit/config.el

@@ -26,7 +26,7 @@ load everything.")
         magit-display-buffer-function #'+magit-display-buffer-fullscreen
         magit-popup-display-buffer-action '((display-buffer-in-side-window)))
 
-  (set-popup-rule! "^\\(?:\\*magit\\|magit:\\)" :ignore)
+  (set-popup-rule! "^\\(?:\\*magit\\|magit:\\)" :ignore t)
   ;; Consider magit buffers real (so they can switched to)
   (add-hook 'magit-mode-hook #'doom|mark-buffer-as-real)
   ;; no mode-line in magit popups

modules/tools/password-store/config.el

@@ -28,9 +28,7 @@
 (after! pass
   (set-env! "PASSWORD_STORE_DIR")
   (set-evil-initial-state! 'pass-mode 'emacs)
-  (set-popup-rule! "^\\*Password-Store"
-    '((side . left) (size . 0.25))
-    '((quit)))
+  (set-popup-rule! "^\\*Password-Store" :side 'left :size 0.25 :quit nil)
   (define-key! pass-mode-map
     "j"    #'pass-next-entry
     "k"    #'pass-prev-entry

modules/tools/pdf/config.el

@@ -34,9 +34,9 @@
     (load! "+modeline")
     (add-hook! 'pdf-tools-enabled-hook (doom-set-modeline 'pdf-tools-modeline)))
   ;; Handle PDF-tools related popups better
-  (set-popup-rule! "^\\*Outline*" '((side . right) (size . 40)) '((select)))
+  (set-popup-rule! "^\\*Outline*" :side 'right :size 40 :select nil)
   ;; TODO: Add additional important windows that should be handled differently
   ;; TODO: These two next rules don't work (they should), investigate
-  ;; (set-popup-rule! "\\*Contents\\*" '((side . right) (size . 40)) nil)
-  ;; (set-popup-rule! "* annots\\*$" '((side . left) (size . 40)) '((select)))
+  ;; (set-popup-rule! "\\*Contents\\*" :side 'right :size 40)
+  ;; (set-popup-rule! "* annots\\*$" :side 'left :size 40 :select nil)
   )