emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

feature/popup: fix incorrect delete-window window parameter #261

Browse source 
A bug that could make popup windows invulnerable to being closed. The
horror!
This commit is contained in:
Henrik Lissner 2018-01-07 06:44:32 -05:00
parent 51084852a6
commit 5f52e21796
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
1 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/feature/popup/autoload.el
View file

@ -30,12 +30,7 @@ and enables `+popup-buffer-mode'."
(with-selected-window window
(set-window-parameter window 'popup t)
(set-window-parameter window 'no-other-window t)
(set-window-parameter
window 'delete-window
;; if set, we still want to call `+popup--destroy' afterwards.
(if-let* ((fn (window-parameter window 'delete-window)))
(lambda (window) (funcall fn window) (+popup--destroy window))
#'+popup--destroy))
(set-window-parameter window 'delete-window #'+popup--destroy)
(window-preserve-size
window (memq (window-parameter window 'window-side)
'(left right)) t)