Respect dash-docs-browser-func

Formerly, `+lookup/in-docsets` would disregard
dash-docs-browser-func (locally setting it to the value of
`+lookup-open-url-fn`). Now only `+lookup/online` respects
+lookup-open-url-fn and `+lookup/in-docsets` respects
`dash-docs-brwoser-func`.

Closes #4795
This commit is contained in:
Henrik Lissner 2021-04-13 22:38:17 -04:00
parent 079feb26e4
commit 5ee8080ca7
2 changed files with 14 additions and 7 deletions

View file

@ -208,21 +208,29 @@ This determines what docsets to implicitly search for when you use
docsets must be installed with ~dash-docset-install-docset~. docsets must be installed with ~dash-docset-install-docset~.
** Open in eww instead of browser ** Open in eww instead of browser
To open results from ~+lookup/online~ or ~+lookup/in-docsets~ in EWW instead ~+lookup/online~ opens the search results with in ~+lookup-open-url-fn~
of your system browser, change ~+lookup-open-url-fn~ (default: (default: ~#'browse-url~). Here is how to change this to EWW (so it opens inside
~#'browse-url~): Emacs):
#+BEGIN_SRC emacs-lisp #+BEGIN_SRC emacs-lisp
(setq +lookup-open-url-fn #'eww) (setq +lookup-open-url-fn #'eww)
#+END_SRC #+END_SRC
#+begin_quote
~+lookup/in-docsets~ consults ~dash-docs-browser-func~ instead, which is already
set to ~#'eww~ by default.
#+end_quote
** Open in Xwidget WebKit instead of browser ** Open in Xwidget WebKit instead of browser
To open results from ~+lookup/online~ or ~+lookup/in-docsets~ in Xwidget To open results from ~+lookup/online~ or ~+lookup/in-docsets~ in Xwidget WebKit
WebKit instead of your system browser, set ~+lookup-open-url-fn~ to instead of your system browser, set ~+lookup-open-url-fn~ and/or
~+lookup-xwidget-webkit-open-url-fn~ (needs Emacs with Xwidgets support): ~dash-docs-browser-func~ to ~+lookup-xwidget-webkit-open-url-fn~ (needs Emacs
with Xwidgets support):
#+BEGIN_SRC emacs-lisp #+BEGIN_SRC emacs-lisp
(setq +lookup-open-url-fn #'+lookup-xwidget-webkit-open-url-fn) (setq +lookup-open-url-fn #'+lookup-xwidget-webkit-open-url-fn)
(after! dash-docs
(setq dash-docs-browser-func #'+lookup-xwidget-webkit-open-url-fn))
#+END_SRC #+END_SRC
* Appendix * Appendix

View file

@ -86,7 +86,6 @@ installed with `dash-docs-install-docset'."
(interactive "P") (interactive "P")
(require 'dash-docs) (require 'dash-docs)
(let ((dash-docs-common-docsets) (let ((dash-docs-common-docsets)
(dash-docs-browser-func +lookup-open-url-fn)
(dash-docs-docsets (dash-docs-docsets
(if arg (if arg
(dash-docs-installed-docsets) (dash-docs-installed-docsets)