From 5cb1d5d4c9960a4ea7a356f76939b7ae082109b8 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Wed, 20 Jun 2018 02:08:34 +0200 Subject: [PATCH] eval-after-load -> with-eval-after-load The way Doom was using eval-after-load ensured its form were never byte-compiled or even checked by the byte-compiler, because they were treated as quoted forms (data), and thus eval'ed. Friends don't let friends use eval. --- core/core-lib.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/core-lib.el b/core/core-lib.el index 6f66cdafe..3ea39d001 100644 --- a/core/core-lib.el +++ b/core/core-lib.el @@ -232,7 +232,8 @@ compilation. This will no-op on features that have been disabled by the user." (put ',fun 'permanent-local-hook t) (add-hook 'after-load-functions #',fun))))) ((symbolp targets) - `(eval-after-load ',targets '(progn ,@body))) + `(with-eval-after-load ',targets + ,@body)) ((and (consp targets) (memq (car targets) '(:or :any))) `(progn