nit(cli): revise comments wrt site-run-file loading

This commit is contained in:
Henrik Lissner 2024-09-01 13:03:31 -04:00
parent 2bc6dd2a96
commit 515f61295b
No known key found for this signature in database
GPG key ID: B60957CA074D39A3
3 changed files with 16 additions and 19 deletions

View file

@ -23,12 +23,12 @@
doom-cache-dir
doom-state-dir))
;; HACK: bin/doom invokes Emacs with --no-site-lisp so that site files can be
;; loaded manually, here, where I can suppress any output it produces, and
;; they almost always produce some. This output pollutes the output of doom
;; scripts with potentially confusing -- but always unimportant --
;; information to the user, like deprecation notices, file-loaded messages,
;; and linter warnings. With this, that output is suppressed.
;; HACK: bin/doom suppresses loading of site files so they can be loaded
;; manually, here. Why? To suppress the otherwise unavoidable output they
;; commonly produce (like deprecation notices, file-loaded messages, and
;; linter warnings). This output pollutes the output of doom's CLI (or
;; scripts derived from it) with potentially confusing or alarming -- but
;; always unimportant -- information to the user.
(quiet!
(require 'cl nil t) ; "Package cl is deprecated"
(unless site-run-file ; unset in doom.el

View file

@ -502,10 +502,10 @@ users).")
;; PERF,UX: site-lisp files are often obnoxiously noisy (emitting output
;; that isn't useful to end-users, like load messages, deprecation
;; notices, and linter warnings. Displaying these in the minibuffer causes
;; unnecessary redraws at startup which can impact startup time
;; drastically and cause flashes of white. It also pollutes the logs. By
;; suppressing it here, I load it myself, later, in a more controlled way
;; notices, and linter warnings). Displaying these in the minibuffer
;; causes unnecessary redraws at startup which can impact startup time
;; drastically and cause flashes of white. It also pollutes the logs. I
;; suppress it here and load it myself, later, in a more controlled way
;; (see `startup--load-user-init-file@undo-hacks').
(put 'site-run-file 'initial-value site-run-file)
(setq site-run-file nil)