From 4ed3e75f5f89b2907d7e78b6701bb0ad7acef273 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Wed, 21 Aug 2024 02:14:57 -0400 Subject: [PATCH] fix(dired): fail gracefully if pdf-tools isn't installed Will throw a "void-variable pdf-info-epdfinfo-program" error if pdf-tools isn't installed (or `:tools pdf` is disabled). --- modules/emacs/dired/config.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/emacs/dired/config.el b/modules/emacs/dired/config.el index 5521bea09..e94673551 100644 --- a/modules/emacs/dired/config.el +++ b/modules/emacs/dired/config.el @@ -213,8 +213,8 @@ Fixes #3939: unsortable dired entries on Windows." (defadvice! +dired--autoload-pdf-tools-a (fn &rest args) :around #'dirvish-pdf-dp (when (equal (nth 1 args) "pdf") - (require 'pdf-tools nil t) - (if (file-exists-p pdf-info-epdfinfo-program) + (if (and (require 'pdf-tools nil t) + (file-exists-p pdf-info-epdfinfo-program)) (apply fn args) '(info . "`epdfinfo' program required to preview pdfs; run `M-x pdf-tools-install'")))))