From 4dfb84211b7867761ed2970ac111e611d9291218 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Wed, 22 Aug 2018 16:29:34 +0200 Subject: [PATCH] feature/lookup: minor refactor --- modules/feature/lookup/autoload/lookup.el | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/modules/feature/lookup/autoload/lookup.el b/modules/feature/lookup/autoload/lookup.el index d74457fe6..9c5ae2201 100644 --- a/modules/feature/lookup/autoload/lookup.el +++ b/modules/feature/lookup/autoload/lookup.el @@ -146,15 +146,15 @@ evil-mode is active." ((and (require 'dumb-jump nil t) ;; dumb-jump doesn't tell us if it succeeded or not - (let ((old-fn (symbol-function 'dumb-jump-get-results)) - successful) - (cl-letf (((symbol-function 'dumb-jump-get-results) - (lambda (&optional prompt) - (let* ((plist (funcall old-fn prompt)) - (results (plist-get plist :results))) - (when (and results (> (length results) 0)) - (setq successful t)) - plist)))) + (let (successful) + (cl-letf* ((old-fn (symbol-function 'dumb-jump-get-results)) + ((symbol-function 'dumb-jump-get-results) + (lambda (&optional prompt) + (let* ((plist (funcall old-fn prompt)) + (results (plist-get plist :results))) + (when (and results (> (length results) 0)) + (setq successful t)) + plist)))) (if other-window (dumb-jump-go-other-window) (dumb-jump-go)) @@ -210,6 +210,7 @@ Goes down a list of possible backends: (require 'helm-dash nil t)) (or (bound-and-true-p counsel-dash-docsets) (bound-and-true-p helm-dash-docsets)) + ;; counsel-dash uses helm-dash under the hood (helm-dash-installed-docsets)) (+lookup/in-docsets identifier))