Introduce general.el & rewrite map!

+ Now uses an overriding keymap for leader keys, so that it is always
  available, even outside of normal/visual states. In insert/emacs
  states, or in sessions where evil is absent, an alternative prefix is
  used for leader/localleader keys. See these variables:
  + doom-leader-prefix
  + doom-leader-alt-prefix
  + doom-localleader-prefix
  + doom-localleader-alt-prefix
+ Keybinds now support alternative prefixes through the new :alt-prefix
  property. This is useful for non-evil users and non-normal evil
  states. By default, this is M-SPC (leader) and M-SPC m (localleader).
+ Removed +evil-commands flag from config/default (moved to
  feature/evil/+commands.el).
+ config/default/+bindings.el has been split into
  config/default/+{evil,emacs}-bindings.el, which one is loaded depends
  on whether evil is present or not. The latter is blank, but will soon
  be populated with a keybinding scheme for non-evil users (perhaps
  inspired by #641).
+ The define-key! macro has been replaced; it is now an alias for
  general-def.
+ Added unmap! as an alias for general-unbind.
+ The following modifier key conventions are now enforced for
  consistency, across all OSes:
    alt/option      = meta
    windows/command = super
  It used to be
    alt/option      = alt
    windows/command = meta
  Many of the default keybinds have been updated to reflect this switch,
  but it is likely to affect personal meta/super keybinds!

The map! macro has also been rewritten to use general-define-key. Here
is what has been changed:

+ map! no longer works with characters, e.g. (map! ?x #'do-something) is
  no longer supported. Keys must be kbd-able strings like "C-c x" or
  vectors like [?C-c ?x].
+ The :map and :map* properties are now the same thing. If specified
  keymaps aren't defined when binding keys, it is automatically
  deferred.
+ The way you bind local keybinds has changed:

    ;; Don't do this
    (map! :l "a" #'func-a
          :l "b" #'func-b)
    ;; Do this
    (map! :map 'local "a" #'func-a
                      "b" #'func-b)

+ map! now supports the following new blocks:
  + (:if COND THEN-FORM ELSE-FORM...)
  + (:alt-prefix PREFIX KEYS...) -- this prefix will be used for
    non-normal evil states. Equivalent to :non-normal-prefix in general.
+ The way you declare a which-key label for a prefix key has changed:

    ;; before
    (map! :desc "label" :prefix "a" ...)
    ;; now
    (map! :prefix ("a" . "label") ...)

+ It used to be that map! supported binding a key to a key sequence,
  like so:

    (map! "a" [?x])  ; pressing a is like pressing x

  This functionality was removed *temporarily* while I figure out the
  implementation.

Addresses: #448, #814, #860
Mentioned in: #940

modules/lang/emacs-lisp/config.el

@@ -62,7 +62,11 @@
   (add-hook! 'emacs-lisp-mode-hook #'(rainbow-delimiters-mode highlight-quoted-mode))
 
   ;; Recenter window after following definition
-  (advice-add #'elisp-def :after #'doom*recenter))
+  (advice-add #'elisp-def :after #'doom*recenter)
+
+  (map! :localleader
+        :map emacs-lisp-mode-map
+        "e" #'macrostep-expand))
 
 
 ;;

modules/lang/latex/+ref.el

@@ -24,7 +24,7 @@
         :localleader :n ";" 'reftex-toc)
   (add-hook! 'reftex-toc-mode-hook
     (reftex-toc-rescan)
-    (map! :local
+    (map! :map 'local
           :e "j"   #'next-line
           :e "k"   #'previous-line
           :e "q"   #'kill-buffer-and-window

modules/lang/markdown/config.el

@@ -23,35 +23,31 @@
   (add-hook 'markdown-mode-hook #'+markdown|set-fill-column-and-line-spacing)
   (add-hook 'markdown-mode-hook #'auto-fill-mode)
 
-  (define-key! markdown-mode-map
-    [remap find-file-at-point] #'markdown-follow-thing-at-point
-    (kbd "M-*") #'markdown-insert-list-item
-    (kbd "M-b") #'markdown-insert-bold
-    (kbd "M-i") #'markdown-insert-italic
-    (kbd "M-`") #'+markdown/insert-del)
-  (when (featurep! :feature evil +everywhere)
-    (evil-define-key* 'motion markdown-mode-map
-      "gj"    #'markdown-next-visible-heading
-      "gk"    #'markdown-previous-visible-heading
-      ;; TODO: Make context sensitive
-      "]h"    #'markdown-next-visible-heading
-      "[h"    #'markdown-previous-visible-heading
-      "[p"    #'markdown-promote
-      "]p"    #'markdown-demote
-      "[l"    #'markdown-previous-link
-      "]l"    #'markdown-next-link)
-    (evil-define-key* 'insert markdown-mode-map
-      (kbd "M--") #'markdown-insert-hr)
-    (evil-define-key* 'normal markdown-mode-map
-      (kbd "M-r") #'browse-url-of-file))
   (map! :map markdown-mode-map
-        :localleader
-        :nv "o" #'markdown-open
-        :nv "b" #'markdown-preview
-        (:prefix "i"
-          :nv "t" #'markdown-toc-generate-toc
-          :nv "i" #'markdown-insert-image
-          :nv "l" #'markdown-insert-link)))
+        [remap find-file-at-point] #'markdown-follow-thing-at-point
+        "M-*" #'markdown-insert-list-item
+        "M-b" #'markdown-insert-bold
+        "M-i" #'markdown-insert-italic
+        "M-`" #'+markdown/insert-del
+        (:when (featurep! :feature evil +everywhere)
+          :m "gj"  #'markdown-next-visible-heading
+          :m "gk"  #'markdown-previous-visible-heading
+          ;; TODO: Make context sensitive
+          :m "]h"  #'markdown-next-visible-heading
+          :m "[h"  #'markdown-previous-visible-heading
+          :m "[p"  #'markdown-promote
+          :m "]p"  #'markdown-demote
+          :m "[l"  #'markdown-previous-link
+          :m "]l"  #'markdown-next-link
+          :i "M--" #'markdown-insert-hr
+          :n "M-r" #'browse-url-of-file)
+        (:localleader
+          "o" #'markdown-open
+          "b" #'markdown-preview
+          (:prefix "i"
+            "t" #'markdown-toc-generate-toc
+            "i" #'markdown-insert-image
+            "l" #'markdown-insert-link))))
 
 (def-package! pandoc-mode
   :when (featurep! +pandoc)

modules/lang/rest/config.el

@@ -15,7 +15,7 @@
       (apply orig-fn args)))
   (advice-add #'restclient-http-do :around #'+rest*permit-self-signed-ssl)
 
-  (map! :mode restclient-mode
+  (map! :map restclient-mode-map
         :n [return] #'+rest/dwim-at-point
         :n "za" #'restclient-toggle-body-visibility
         :n "zm" #'+rest/fold-all