General refactors & appease byte-compiler

core/autoload/packages.el

@@ -210,7 +210,8 @@ ones."
   "Return an alist mapping package names (strings) to pinned commits (strings)."
   (let (alist)
     (dolist (package doom-packages alist)
-      (with-plist! (cdr package) (recipe modules disable ignore pin unpin)
+      (cl-destructuring-bind (_ &key disable ignore pin unpin &allow-other-keys)
+          package
         (when (and (not ignore)
                    (not disable)
                    (or pin unpin))
@@ -223,7 +224,9 @@ ones."
   "Return an alist mapping package names (strings) to pinned commits (strings)."
   (let (alist)
     (dolist (package doom-packages alist)
-      (with-plist! (cdr package) (recipe modules disable ignore pin unpin)
+      (cl-destructuring-bind
+          (_ &key recipe disable ignore pin unpin &allow-other-keys)
+          package
         (when (and (not ignore)
                    (not disable)
                    (or unpin

core/autoload/projects.el

@@ -1,6 +1,8 @@
 ;;; core/autoload/projects.el -*- lexical-binding: t; -*-
 
-(defvar projectile-project-root nil)
+(defvar projectile-enable-caching)
+(defvar projectile-project-root)
+(defvar projectile-require-project-root)
 
 ;;;###autoload (autoload 'projectile-relevant-known-projects "projectile")
 

core/autoload/scratch.el

@@ -96,6 +96,7 @@ following:
 ;;
 ;;; Commands
 
+(defvar projectile-enable-caching)
 ;;;###autoload
 (defun doom/open-scratch-buffer (&optional arg project-p)
   "Pop up a persistent scratch buffer.

core/autoload/text.el

@@ -117,6 +117,9 @@ in some cases."
 ;;; Commands
 
 (defun doom--bol-bot-eot-eol (&optional pos)
+  (save-excursion
+    (when pos
+      (goto-char pos))
     (let* ((bol (if visual-line-mode
                     (save-excursion
                       (beginning-of-visual-line)
@@ -144,7 +147,7 @@ in some cases."
                           (forward-char))
                         (point)))
                     eol)))
-    (list bol bot eot eol)))
+      (list bol bot eot eol))))
 
 (defvar doom--last-backward-pt nil)
 ;;;###autoload
@@ -154,7 +157,7 @@ beginning of the line. The opposite of
 `doom/forward-to-last-non-comment-or-eol'."
   (interactive "d")
   (let ((pt (or point (point))))
-    (cl-destructuring-bind (bol bot _eot eol)
+    (cl-destructuring-bind (bol bot _eot _eol)
         (doom--bol-bot-eot-eol pt)
       (cond ((> pt bot)
              (goto-char bot))

modules/app/calendar/autoload.el

@@ -3,9 +3,9 @@
 (defvar +calendar--wconf nil)
 
 (defun +calendar--init ()
-  (if-let* ((win (cl-loop for win in (doom-visible-windows)
-                          if (string-match-p "^\\*cfw:" (buffer-name (window-buffer win)))
-                          return win)))
+  (if-let (win (cl-find-if (lambda (b) (string-match-p "^\\*cfw:" (buffer-name b)))
+                           (doom-visible-windows)
+                           :key #'window-buffer))
       (select-window win)
     (call-interactively +calendar-open-function)))
 

modules/editor/evil/config.el

@@ -126,7 +126,7 @@ directives. By default, this only recognizes C directives.")
                  (count-lines (point-min) (point-max))
                  (buffer-size)))))
 
-  ;; 'gq' moves the cursor to the beginning of selection. Disable this, since
+  ;; '=' moves the cursor to the beginning of selection. Disable this, since
   ;; it's more disruptive than helpful.
   (defadvice! +evil--dont-move-cursor-a (orig-fn &rest args)
     :around #'evil-indent

modules/term/eshell/autoload/company.el

@@ -3,6 +3,7 @@
 
 ;; REVIEW Refactor me
 
+(defvar pcomplete-suffix-list)
 (defvar company-pcomplete-available 'unknown)
 
 (defun company-pcomplete--prefix ()