emacs/vc: refactor

And declare vc, vc-annotate & smerge-mode as built-ins (for
doom/help-packages).

modules/emacs/vc/config.el

@@ -1,6 +1,8 @@
 ;;; emacs/vc/config.el -*- lexical-binding: t; -*-
 
-;; `git-timemachine'
+(setq vc-make-backup-files nil)
+
+
 (after! git-timemachine
   ;; Sometimes I forget `git-timemachine' is enabled in a buffer, so instead of
   ;; showing revision details in the minibuffer, show them in
@@ -16,9 +18,12 @@
     (add-transient-hook! #'git-timemachine-blame (require 'magit-blame))))
 
 
-;; `git-commit-mode'
-(after! git-commit-mode
-  (set-yas-minor-mode! 'git-commit-mode))
+;;;###package git-commit
+(def-package! git-commit
+  :after-call after-find-file
+  :config
+  (global-git-commit-mode +1)
+  (set-yas-minor-mode! 'git-commit-mode)
 
   (defun +vc|enforce-git-commit-conventions ()
     "See https://chris.beams.io/posts/git-commit/"
@@ -33,16 +38,8 @@ otherwise in default state."
     (when (and (bound-and-true-p evil-mode)
                (bobp) (eolp))
       (evil-insert-state)))
-(add-hook 'git-commit-setup-hook #'+vc|start-in-insert-state-maybe)
+  (add-hook 'git-commit-setup-hook #'+vc|start-in-insert-state-maybe))
 
-
-;;
-;; `vc' (built-in)
-
-;; `vc-hooks'
-(setq vc-make-backup-files nil)
-
-;; `vc-annotate'
 (after! vc-annotate
   (set-popup-rules!
     '(("^\\vc-d" :select nil) ; *vc-diff*
@@ -51,7 +48,6 @@ otherwise in default state."
     '(vc-annotate-mode vc-git-log-view-mode)
     'normal))
 
-;; `smerge-mode'
 (after! smerge-mode
   (unless EMACS26+
     (with-no-warnings

modules/emacs/vc/packages.el

@@ -1,6 +1,10 @@
 ;; -*- no-byte-compile: t; -*-
 ;;; emacs/vc/packages.el
 
+(package! vc :built-in t)
+(package! vc-annotate :built-in t)
+(package! smerge-mode :built-in t)
+
 (package! git-link)
 (package! git-timemachine)
 (package! gitconfig-mode)