From 43ebba886f2179835ab3438a82394c376497faf9 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Mon, 26 Aug 2019 14:57:24 -0400 Subject: [PATCH] lang/javascript: fix eldoc in tide-mode --- modules/lang/javascript/config.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/lang/javascript/config.el b/modules/lang/javascript/config.el index 6a46604f2..a266805aa 100644 --- a/modules/lang/javascript/config.el +++ b/modules/lang/javascript/config.el @@ -176,10 +176,12 @@ to tide." ;; cleanup tsserver when no tide buffers are left (add-hook! 'tide-mode-hook (add-hook 'kill-buffer-hook #'+javascript-cleanup-tide-processes-h nil t)) + ;; Eldoc is activated too soon and disables itself, thinking there is no eldoc ;; support in the current buffer, so we must re-enable it later once eldoc - ;; support exists. - (add-hook 'tide-mode-hook #'eldoc-mode) + ;; support exists. It is set *after* tide-mode is enabled, so enabling it on + ;; `tide-mode-hook' is too early, so... + (advice-add #'tide-setup :after #'eldoc-mode) (define-key tide-mode-map [remap +lookup/documentation] #'tide-documentation-at-point)