emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Refactor def-setting!/set! implementation

Browse source 
The `doom-settings` variable has been removed. Setting checks are done
with fboundp now, which is simpler.
This commit is contained in:
Henrik Lissner 2018-06-02 16:23:50 +02:00
parent 385cb476ba
commit 428f1e1d07
No known key found for this signature in database
GPG key ID: 5F6C0EA160557395
3 changed files with 25 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

17
core/autoload/help.el
View file

@ -68,13 +68,20 @@
Defaults to the "
(interactive
(let ((sym (symbol-at-point)))
(let ((settings (cl-loop with case-fold-search = nil
for sym being the symbols of obarray
for sym-name = (symbol-name sym)
if (string-match "^doom--set\\(:.+\\)" sym-name)
collect (match-string 1 sym-name)))
(sym (symbol-at-point)))
(list (completing-read "Describe setting: "
(sort (mapcar #'car doom-settings) #'string-lessp)
(sort settings #'string-lessp)
nil t (if (keywordp sym) (symbol-name sym))))))
(let ((fn (cdr (assq (intern setting) doom-settings))))
(unless fn
(error "'%s' is not a valid DOOM setting" setting))
(or (stringp setting)
(signal 'wrong-type-argument (list 'stringp setting)))
(let ((fn (intern-soft (format "doom--set%s" setting))))
(or (fboundp fn)
(error "'%s' is not a valid DOOM setting" setting))
(describe-function fn)))
;;;###autoload