From 41289cfef6fcf785a0b789d0dd6c8fdeff9acb09 Mon Sep 17 00:00:00 2001 From: Colin Woodbury Date: Sun, 31 Dec 2023 22:57:21 +0900 Subject: [PATCH] fix(lib): doom/bumpify-diff: respect structure of given list The old check was a bug fix to work around noisy values that somehow made it into diff checks. The `package!` symbol is never actually present in the list of values yielded by the search in `read-package`, so this commit alters the lookup to respect what is actually present, thus guaranteeing that `destructuring-bind` succeeds and bump diffs are actually detected. --- lisp/lib/packages.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/lib/packages.el b/lisp/lib/packages.el index 496091155..0b86a9085 100644 --- a/lisp/lib/packages.el +++ b/lisp/lib/packages.el @@ -239,7 +239,7 @@ Must be run from a magit diff buffer." (unless (= (length before) (length after)) (user-error "Uneven number of packages being bumped")) (dolist (p1 before) - (when (and (listp p1) (eq (car p1) 'package!)) + (when (and (listp p1) (plist-get (cdr p1) :package)) (cl-destructuring-bind (package &key plist _beg _end &allow-other-keys) p1 (let ((p2 (cdr (assq package after)))) (if (null p2)