From 3dd34abe61e62d14955211e449e6be789f241f3f Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Sat, 22 Dec 2018 03:56:05 -0500 Subject: [PATCH] Remove hide-undefined-binds advice for which-key Before general.el was introduced to Doom, commands were bound to keys whether or not their containing modules were enabled. This was out of laziness and readability. I intend to change this, as such it is no longer necessary to hide unavailable keybinds from which-key. --- core/core-ui.el | 8 -------- 1 file changed, 8 deletions(-) diff --git a/core/core-ui.el b/core/core-ui.el index 37f0c65d5..5f2ac22d4 100644 --- a/core/core-ui.el +++ b/core/core-ui.el @@ -154,14 +154,6 @@ size.") ;; take Emacs 26 line numbers into account (+ (if EMACS26+ 6 0) fill-column)) -(defun doom*hide-undefined-which-key-binds (bindings) - (cl-loop for bind in bindings - if (or (member (cdr bind) '("Prefix Command" "??")) - (fboundp (intern (cdr bind)))) - collect bind)) -(advice-add #'which-key--get-current-bindings :filter-return #'doom*hide-undefined-which-key-binds) -(advice-add #'which-key--get-keymap-bindings :filter-return #'doom*hide-undefined-which-key-binds) - ;; ;; Built-in packages