From 3af07d2500231a4fe45c4cf86408d2e358a648d0 Mon Sep 17 00:00:00 2001 From: "Itai Y. Efrat" Date: Sat, 31 Jul 2021 10:50:00 +0300 Subject: [PATCH] fix(vertico): `+vertico/embark-preview` bug - replace obsolete `embark-default-action` with `embark-dwim` - add `defvar` for `embark-quiet-after-action` to fix lexical var bug --- modules/completion/vertico/autoload/vertico.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/modules/completion/vertico/autoload/vertico.el b/modules/completion/vertico/autoload/vertico.el index 89da20c7f..654436567 100644 --- a/modules/completion/vertico/autoload/vertico.el +++ b/modules/completion/vertico/autoload/vertico.el @@ -4,6 +4,10 @@ ;;;###autoload (defvar orderless-match-faces) +;; To prevent "Defining as dynamic an already lexical var" from +vertico/embark-preview +;;;###autoload +(defvar embark-quit-after-action) + ;;;###autoload (defadvice! +vertico--company-capf--candidates-a (fn &rest args) "Highlight company matches correctly, and try default completion styles before @@ -146,7 +150,7 @@ Supports exporting consult-grep to wgrep, file to wdeired, and consult-location (unless (bound-and-true-p consult--preview-function) (save-selected-window (let ((embark-quit-after-action nil)) - (embark-default-action))))) + (embark-dwim))))) ;;;###autoload (defun +vertico/next-candidate-preview (&optional n)