From 321f2d2249a5a933e4a4a3ef684e30ce0a7a74cf Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Mon, 1 Jul 2024 18:21:35 -0400 Subject: [PATCH] refactor!(org): remove org-yt BREAKING CHANGE: This removes the org-yt package, which will break [[yt:...]] links in org, if you're using them. The package is a source of errors, likely because it hasn't been updated for Org's new element parsing system. This package was originally included for eventual use in Doom's documentation, but it likely won't be used and isn't universally useful enough to keep in this module by default. Fix: #7913 Fix: #7317 --- modules/lang/org/README.org | 1 - modules/lang/org/config.el | 10 +--------- modules/lang/org/packages.el | 3 --- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/modules/lang/org/README.org b/modules/lang/org/README.org index 031bcd0f5..6e84b5645 100644 --- a/modules/lang/org/README.org +++ b/modules/lang/org/README.org @@ -111,7 +111,6 @@ https://www.mfoot.com/blog/2015/11/22/literate-emacs-configuration-with-org-mode - [[doom-package:org-pomodoro]] if [[doom-module:+pomodoro]] - [[doom-package:org-roam]] (v1) if [[doom-module:+roam]] - [[doom-package:org-roam]] (v2) if [[doom-module:+roam2]] -- [[doom-package:org-yt]] - [[doom-package:ox-clip]] - [[doom-package:ox-hugo]] if [[doom-module:+hugo]] - [[doom-package:ox-pandoc]] if [[doom-module:+pandoc]] diff --git a/modules/lang/org/config.el b/modules/lang/org/config.el index 48ca5ee47..b00f73716 100644 --- a/modules/lang/org/config.el +++ b/modules/lang/org/config.el @@ -656,15 +656,7 @@ relative to `org-directory', unless it is an absolute path." (setq org-display-remote-inline-images 'download) ; TRAMP urls (org-link-set-parameters "http" :image-data-fun #'+org-http-image-data-fn) (org-link-set-parameters "https" :image-data-fun #'+org-http-image-data-fn) - (org-link-set-parameters "img" :image-data-fun #'+org-inline-image-data-fn) - - ;; Add support for youtube links + previews - (require 'org-yt nil t) - - (defadvice! +org-dont-preview-if-disabled-a (&rest _) - "Make `org-yt' respect `org-display-remote-inline-images'." - :before-while #'org-yt-image-data-fun - (not (eq org-display-remote-inline-images 'skip)))) + (org-link-set-parameters "img" :image-data-fun #'+org-inline-image-data-fn)) (defun +org-init-export-h () diff --git a/modules/lang/org/packages.el b/modules/lang/org/packages.el index 02d9620d6..39ac5456a 100644 --- a/modules/lang/org/packages.el +++ b/modules/lang/org/packages.el @@ -39,9 +39,6 @@ (package! avy) (package! htmlize :pin "ed5e5b05fd260e8f161a488d56f10e7f6e01fb75") -(package! org-yt - :recipe (:host github :repo "TobiasZawada/org-yt") - :pin "56166f48e04d83668f70ed84706b7a4d8b1e5438") (package! ox-clip :pin "a549cc8e1747beb6b7e567ffac27e31ba45cb8e8") (package! toc-org :pin "6d3ae0fc47ce79b1ea06cabe21a3c596395409cd") (package! org-cliplink :pin "13e0940b65d22bec34e2de4bc8cba1412a7abfbc")