From 2e5307e4259281d1a233fb1bc99975d528650d53 Mon Sep 17 00:00:00 2001 From: 45mg <45mg@no.mail> Date: Sat, 14 Sep 2024 05:52:08 +0000 Subject: [PATCH] fix(emacs-lisp): always try Helpful for doc lookup As per the description in 6671adc68, this module should always use Helpful's functions as long as Helpful is available (ie. not explicitly disabled by the user in packages.el). The remapping of `describe-symbol` is irrelevant here - the user might prefer to rebind `C-h C-o` to `describe-symbol` (as `helpful-symbol` cannot look up types), but that doesn't necessarily mean they want this module not to use it. --- modules/lang/emacs-lisp/autoload.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/lang/emacs-lisp/autoload.el b/modules/lang/emacs-lisp/autoload.el index e003de2e2..fd8e0b343 100644 --- a/modules/lang/emacs-lisp/autoload.el +++ b/modules/lang/emacs-lisp/autoload.el @@ -117,8 +117,9 @@ if it's callable, `apropos' otherwise." (org-show-hidden-entry)))) 'deferred)) (thing - (funcall (or (command-remapping #'describe-symbol) - #'describe-symbol) + (funcall (if (fboundp #'helpful-symbol) + #'helpful-symbol + #'describe-symbol) (intern thing))) ((call-interactively (if (fboundp #'helpful-at-point)