From 2b1f6031b2972929e599c1247131c3114c8eddd8 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Tue, 6 Sep 2022 23:51:44 +0200 Subject: [PATCH] refactor(lib): rely less on global state for defaults I prefer to be more explicit about these variables' defaults, then to rely on proper load order and unverified global state to ensure they're properly set. --- lisp/doom-cli.el | 3 +++ lisp/lib/print.el | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/doom-cli.el b/lisp/doom-cli.el index 202a2d977..0a06e5034 100644 --- a/lisp/doom-cli.el +++ b/lisp/doom-cli.el @@ -21,6 +21,9 @@ doom-print-level 'debug) (message "Debug mode enabled")) + ;; FIX: All output via `message' should be seen as debug output. + (setq doom-print-message-level 'debug) + ;; HACK: Load `cl' and site files manually to prevent polluting logs and ;; stdout with deprecation and/or file load messages. (when noninteractive diff --git a/lisp/lib/print.el b/lisp/lib/print.el index 74cee4ad8..09f031a4d 100644 --- a/lisp/lib/print.el +++ b/lisp/lib/print.el @@ -115,13 +115,13 @@ Any of these classes can be called like functions from within `format!' and Accepts `ansi' and `text-properties'. `nil' means don't render styles at all.") -(defvar doom-print-level (if init-file-debug 'debug 'info) +(defvar doom-print-level 'info "The default level of messages to print.") (defvar doom-print-logging-level 'debug "The default logging level used by `doom-log'/`doom-print'.") -(defvar doom-print-message-level (if noninteractive 'debug 'info) +(defvar doom-print-message-level 'info "The default logging level used by `message'.") (defvar doom-print--levels