From 9f5ae41037469e4510c600f565060d9bb4d319b3 Mon Sep 17 00:00:00 2001 From: Leo Alekseyev Date: Wed, 10 Jun 2020 20:38:39 -0700 Subject: [PATCH 1/2] This fixes https://github.com/hlissner/doom-emacs/issues/3348 I am not sure what the setting + removing hook code in use-package! winner was trying to accomplish, but it was breaking winner-redo functionality. This patch fixes the issue. --- core/core-ui.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core/core-ui.el b/core/core-ui.el index 9bd04edf9..f4e3523d8 100644 --- a/core/core-ui.el +++ b/core/core-ui.el @@ -450,10 +450,9 @@ windows, switch to `doom-fallback-buffer'. Otherwise, delegate to original (use-package! winner ;; undo/redo changes to Emacs' window layout - :hook (window-configuration-change . winner-mode) :preface (defvar winner-dont-bind-my-keys t) ; I'll bind keys myself :config - (remove-hook 'window-configuration-change #'winner-mode) + (add-hook 'doom-first-buffer-hook #'winner-mode) (appendq! winner-boring-buffers '("*Compile-Log*" "*inferior-lisp*" "*Fuzzy Completions*" "*Apropos*" "*Help*" "*cvs*" "*Buffer List*" "*Ibuffer*" From dbb48b73609270376311d243e55dcb6ad5e4665f Mon Sep 17 00:00:00 2001 From: Leo Alekseyev Date: Wed, 10 Jun 2020 23:23:17 -0700 Subject: [PATCH 2/2] Changing add-hook in :config of use-package to :hook --- core/core-ui.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/core-ui.el b/core/core-ui.el index f4e3523d8..6f549ec0e 100644 --- a/core/core-ui.el +++ b/core/core-ui.el @@ -451,8 +451,8 @@ windows, switch to `doom-fallback-buffer'. Otherwise, delegate to original (use-package! winner ;; undo/redo changes to Emacs' window layout :preface (defvar winner-dont-bind-my-keys t) ; I'll bind keys myself + :hook (doom-first-buffer . winner-mode) :config - (add-hook 'doom-first-buffer-hook #'winner-mode) (appendq! winner-boring-buffers '("*Compile-Log*" "*inferior-lisp*" "*Fuzzy Completions*" "*Apropos*" "*Help*" "*cvs*" "*Buffer List*" "*Ibuffer*"