replace go-add-tags with go-tag

go-add-tags isn't maintained and has a few issues.
This library will fix those issues by using a binary intended for this.
This commit is contained in:
Bastien Rivière 2019-11-06 14:22:24 +01:00
parent 9cb535043c
commit 1fcf210bd4
4 changed files with 9 additions and 3 deletions

View file

@ -36,7 +36,7 @@ This module adds [[https://golang.org][Go]] support.
+ [[https://github.com/syohex/emacs-go-eldoc][go-eldoc]] + [[https://github.com/syohex/emacs-go-eldoc][go-eldoc]]
+ [[https://github.com/dominikh/go-mode.el][go-guru]] + [[https://github.com/dominikh/go-mode.el][go-guru]]
+ [[https://github.com/manute/gorepl-mode][gorepl-mode]] + [[https://github.com/manute/gorepl-mode][gorepl-mode]]
+ [[https://github.com/syohex/emacs-go-add-tags][go-add-tags]] + [[https://github.com/brantou/emacs-go-tag][go-tag]]
+ [[https://github.com/mdempsky/gocode][company-go]]* + [[https://github.com/mdempsky/gocode][company-go]]*
+ [[https://github.com/s-kostyaev/go-gen-test][go-gen-test]] + [[https://github.com/s-kostyaev/go-gen-test][go-gen-test]]
@ -69,6 +69,7 @@ This module requires a valid ~GOPATH~, and the following Go packages:
+ ~guru~ (for code navigation & refactoring commands) + ~guru~ (for code navigation & refactoring commands)
+ ~goimports~ (optional: for auto-formatting code on save & fixing imports) + ~goimports~ (optional: for auto-formatting code on save & fixing imports)
+ ~gotests~ (for generate test code) + ~gotests~ (for generate test code)
+ ~gomodifytags~ (for manipulating tags)
#+BEGIN_SRC sh #+BEGIN_SRC sh
export GOPATH=~/work/go export GOPATH=~/work/go
@ -80,6 +81,7 @@ go get -u golang.org/x/tools/cmd/goimports
go get -u golang.org/x/tools/cmd/gorename go get -u golang.org/x/tools/cmd/gorename
go get -u golang.org/x/tools/cmd/guru go get -u golang.org/x/tools/cmd/guru
go get -u github.com/cweill/gotests/... go get -u github.com/cweill/gotests/...
go get -u github.com/fatih/gomodifytags
#+END_SRC #+END_SRC
* TODO Features * TODO Features

View file

@ -25,7 +25,8 @@
(map! :map go-mode-map (map! :map go-mode-map
:localleader :localleader
"a" #'go-add-tags "a" #'go-tag-add
"d" #'go-tag-remove
"e" #'+go/play-buffer-or-region "e" #'+go/play-buffer-or-region
"i" #'go-goto-imports ; Go to imports "i" #'go-goto-imports ; Go to imports
(:prefix ("h" . "help") (:prefix ("h" . "help")

View file

@ -14,6 +14,9 @@
(unless (executable-find "gotests") (unless (executable-find "gotests")
(warn! "Couldn't find gotests. Generating tests will not work")) (warn! "Couldn't find gotests. Generating tests will not work"))
(unless (executable-find "gomodifytags")
(warn! "Couldn't find gomodifytags. Manipulating struct tags will not work"))
(when (featurep! :completion company) (when (featurep! :completion company)
(require 'company-go) (require 'company-go)
(unless (executable-find company-go-gocode-command) (unless (executable-find company-go-gocode-command)

View file

@ -5,7 +5,7 @@
(package! go-guru) (package! go-guru)
(package! go-mode) (package! go-mode)
(package! gorepl-mode) (package! gorepl-mode)
(package! go-add-tags) (package! go-tag)
(package! go-gen-test) (package! go-gen-test)
(when (featurep! :completion company) (when (featurep! :completion company)