From 1b6cf5777a42181f6276cfa3db54916a8aa5efde Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Sun, 10 Jan 2021 04:49:00 -0500 Subject: [PATCH] Fix void-variable eshell-modules-list Only affected Emacs 26 users. --- modules/term/eshell/config.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/term/eshell/config.el b/modules/term/eshell/config.el index 33458f007..d1e52b065 100644 --- a/modules/term/eshell/config.el +++ b/modules/term/eshell/config.el @@ -73,8 +73,6 @@ You should use `set-eshell-alias!' to change this.") eshell-glob-case-insensitive t eshell-error-if-no-glob t) - (add-to-list 'eshell-modules-list 'eshell-tramp) - ;; Consider eshell buffers real (add-hook 'eshell-mode-hook #'doom-mark-buffer-as-real-h) @@ -105,6 +103,10 @@ You should use `set-eshell-alias!' to change this.") ;; or configure `+eshell-aliases' via elisp. (advice-add #'eshell-write-aliases-list :override #'ignore) + ;; REVIEW In Emacs 27 and newer, waiting for esh-module is unnecessary. + (after! esh-module + (add-to-list 'eshell-modules-list 'eshell-tramp)) + ;; Visual commands require a proper terminal. Eshell can't handle that, so ;; it delegates these commands to a term buffer. (after! em-term