From 177157b044f05fb7d166ec80a0a6ddc361d9b873 Mon Sep 17 00:00:00 2001 From: StrawberryTea Date: Mon, 24 Jul 2023 13:18:53 -0400 Subject: [PATCH] fix(popup): cycle windows with no-other-window property Previously, +popup/other would do nothing if a window with the no-other-window property that was not a popup was focused. Now +popup/other will always select different window if there is another popup or window with the no-other-window property. Fix: #7119 --- modules/ui/popup/autoload/popup.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ui/popup/autoload/popup.el b/modules/ui/popup/autoload/popup.el index 51e944ba2..78119aec7 100644 --- a/modules/ui/popup/autoload/popup.el +++ b/modules/ui/popup/autoload/popup.el @@ -355,7 +355,8 @@ Any non-nil value besides the above will be used as the raw value for ;; parameter, since `other-window' won't. (window-parameter w 'no-other-window))) (window-list))) - (select-window (if (+popup-window-p) + (select-window (if (or (+popup-window-p) + (window-parameter nil 'no-other-window)) (let ((window (selected-window))) (or (car-safe (cdr (memq window popups))) (car (delq window popups))